Text not visible for hide button on macOS #301

1. 
   brunoerg commented at 10:16 pm on April 27, 2021: contributor

   On the modal, it is not possible to read the button text. I think the text color is the same of the background one making it unreadable. I tested it on Windows 10 and seems ok.

   

   MacOS 11.1 - compiled from 0.21 (./autogen.sh && ./configure && make -j “$(($(sysctl -n hw.physicalcpu)+1))”)

2. brunoerg added the label Bug on Apr 27, 2021
3. 
   jarolrod commented at 11:43 pm on April 27, 2021: member

   what system (OS Version, Qt version). Is this compiled? Built through depends? Please provide more information
4. 
   hebasto commented at 8:52 am on April 28, 2021: member

   @brunoerg

   Has Bitcoin Core window a focus?

5. 
   brunoerg commented at 10:54 am on April 28, 2021: contributor

   @hebasto yes!
6. 
   brunoerg commented at 11:37 am on April 28, 2021: contributor

   I forgot that, sorry! Updated. @jarolrod
7. 
   jarolrod commented at 3:29 pm on April 28, 2021: member

   @brunoerg the window does not have focus in your screenshot as the exit buttons in the top left are not colorized. If you click on the bitcoin-qt window again, does the color show back up on the button?
8. 
   brunoerg commented at 3:42 pm on April 28, 2021: contributor

   @brunoerg In the screenshot is not, but I tested it with focus. Same thing here.
9. 
   brunoerg commented at 3:42 pm on April 28, 2021: contributor

   I’ll disable dark mode to test it.
10. 
    brunoerg commented at 3:45 pm on April 28, 2021: contributor

    @jarolrod

    https://user-images.githubusercontent.com/19480819/116432993-79738b00-a81f-11eb-84dd-41ce8a880f70.mov

11. 
    jarolrod commented at 7:36 pm on April 29, 2021: member

    @brunoerg that recording shows a bug with theme switching that would be fixed by #275
12. 
    brunoerg commented at 7:49 pm on April 29, 2021: contributor

    @jarolrod Thanks, I will test that! But I am not sure if the concept is the same.
13. 
    hebasto commented at 7:56 pm on April 29, 2021: member

    @jarolrod

    @brunoerg that recording shows a bug with theme switching that would be fixed by #275

    Not for now.

    It’d better to replace this UI-element with something better…

14. hebasto added the label UI on May 8, 2021
15. 
    hebasto commented at 9:25 pm on May 30, 2021: member

    The “Hide” button is a part of the ModalOverlay widget which is customized with style sheets. In cases of conflicts with other customization (e.g., macOS style plugin), style sheets could take precedence.

    To avoid such conflicts, I see the following options:

    • replace the “Hide” button with a QLabel “Press ESC to bla-bla…”, and listen to the “press ESC” event
    • rework ModalOverlay widget to avoid style sheets using
    • drop ModalOverlay widget altogether

Contributors
brunoerg jarolrod hebasto

Labels
Bug UI