Remove indented/raised borders elements on Windows #303

1. 
   Bosch-0 commented at 0:11 am on April 29, 2021: none

   Somewhere between the last GUI update and current master 4cfe6c37d956be58e6228f50833d25b84aafe55a the Windows version of the GUI has these indented / raised border designs applied to them which has resulted in a very visually cluttered GUI. I think this style is only visually bad on Windows as other recent screenshots of master from macOS / Linux don’t seem to be effected. Below is an example from the overview section:

   

   It has also made the sections more condensed as I assume each widget has a size constraint and these borders are taking up extra space. It would be much more visually appealing to have this reverted back to the old style (like in the before above).

2. Bosch-0 added the label Feature on Apr 29, 2021
3. 
   RandyMcMillan commented at 0:44 am on April 29, 2021: contributor

   Is it possible that these “flat” properties being removed is the cause?

   https://github.com/bitcoin-core/gui/commit/67c59ae4793b1a5ebe0c4c542abf3c095e6a658b#diff-bf3f2d3ef0cdd76cd0ee7ed2bfbdea67f03c24a4b85fcfde206acc291e31b4af

4. 
   jarolrod commented at 0:48 am on April 29, 2021: member

   That is an issue with your local qt installation, you have an old version of qt building the GUI.
5. 
   jarolrod commented at 0:50 am on April 29, 2021: member

   @RandyMcMillan that has nothing to do with this issue. That removed a flat property on a button
6. 
   Bosch-0 commented at 0:57 am on April 29, 2021: none

   Mmh not sure how it would be doing that I haven’t configured anything - I’ll re-build.
7. 
   jarolrod commented at 3:33 am on April 29, 2021: member

   @Bosch-0 can you take a Screenshot of the About Qt window
8. 
   Bosch-0 commented at 4:35 am on April 29, 2021: none

   Seems its the latest version?

   

9. 
   Bosch-0 commented at 1:50 am on April 30, 2021: none

   Seems other using windows are also experiencing this when building - #300
10. hebasto removed the label Feature on May 8, 2021
11. hebasto added the label UI on May 8, 2021
12. 
    hebasto commented at 8:22 pm on May 8, 2021: member

    Confirming. Could this be a difference between Qt 5.9.8 and Qt 5.12.10 (https://github.com/bitcoin/bitcoin/pull/21376)?
13. 
    hebasto commented at 9:09 pm on May 8, 2021: member

    @Bosch-0

    ~Do you mind testing #322?~ UPDATE: see https://github.com/bitcoin/bitcoin/pull/22133

14. 
    hebasto commented at 6:40 pm on June 2, 2021: member

    @Bosch-0

    The right solution is https://github.com/bitcoin/bitcoin/pull/22133. Thanks to @jarolrod!

15. 
    Bosch-0 commented at 1:45 am on June 3, 2021: none

    Will test that asap, ty @jarolrod
16. fanquake closed this on Jun 3, 2021

    ---

17. DeckerSU referenced this in commit 7eecef841c on Nov 15, 2021
18. TheComputerGenie referenced this in commit b329ee9825 on Jan 5, 2022
19. bitcoin-core locked this on Aug 16, 2022

Contributors
Bosch-0 RandyMcMillan jarolrod hebasto

Labels
UI