Picking up #290
Original PR Description:
Peer Id to Peer to allow resizing the column more tightly (this will be particularly useful after #256) and does the same for the peer details area.While here, we also add Qt translator comments for the Peer Table columns.
| Master | PR |
|---|---|
 |
 |
to allow resizing the column more tightly
Update from 4ed95c0 -> 73a91c6
Changes:
- renames the peers tab column header from
Peer IdtoPeerto allow resizing the column more tightly
If saving of the horizontal space is the motivation, leaving just “ID” or “id” is strictly better approach for the following reasons:
Also, #290 (comment)
Did you consider how it will look on a long-running node when one-digit id peer is next to, say, four-digit id one?
I considered it carefully and described some of that process in the parent PR description: “center-aligns the entries in the Peer column to align them under the column header rather than to the left (I also tried right-alignment but the values are unreadably close to the Address values and it seems more esthetic to be aligned under the header).”
Ideally they would be right-justified like in -netinfo. Center is still ok and under the header. Left for numbers doesn’t make sense to me.
leaving just “ID” or “id” is strictly better approach
Hm, I disagree for the reasons I already described in the parent PR.
For laypeople (not devs or database people), the right word here is probably “number”, “peer number” or just “peer”, as “number” is self-understood. Of those three, peer is the shortest, and shorter than 4 characters doesn’t make sense to consider as these peer numbers don’t take long to reach 5+ digits anyway.
“ID” means “identification” and in common use, your ID card. “Show me some ID” is what the police officer or the security guard would ask you.
“Id” is a word from Freudian psychology IIRC.
Maybe a good solution is to have native speakers of each language decide on the best word for that language, and in cases where the English-as-a-first-language and English-as-a-second-language-or-as-dev-jargon differ, provide helpful translation hints in the translator comments.
Maybe a good solution is to have native speakers of each language decide on the best word for that language, and in cases where the English-as-a-first-language and English-as-a-second-language-or-as-dev-jargon differ, provide helpful translation hints in the translator comments.
Agree!
№ - numero will work..
Interesting, it is a standard abbreviation in French, TIL it exists in English. I like it better than ID, not sure how well known it is and what the GUI policy is regarding signs/symbols/abbreviations.
In this old PR #135 “ID” looked ok…
Updated from 73a91c63ec72e62ef76fbc857baff14b099a1358 -> b405f19c953d9cd5aa90b66001c31cc58230fb78 (pr311.02, pr311.03, diff)
Changes:
ID vs Peer78+ const QStringList columns{
79+ /*: Title of Peers Table column which contains a
80+ unique number used to identify a connection. */
81+ tr("Peer"),
82+ /*: Title of Peers Table column which contains the
83+ IP/Onion/I2P address we used to connect to the peer. */
Title of the Peers Table column which contains the IP/Onion/I2P address of the connected peer
“column for the peer address” ?
(reviewing from my phone so apologies if a bit out of context)
81+ tr("Peer"),
82+ /*: Title of Peers Table column which contains the
83+ IP/Onion/I2P address we used to connect to the peer. */
84+ tr("Address"),
85+ /*: Title of Peers Table column which contains a value for
86+ the type of connection we have established with the peer.
agree that “we have established” sounds like outbound
“which describes the type of peer connection” ?
85+ /*: Title of Peers Table column which contains a value for
86+ the type of connection we have established with the peer.
87+ Type is a term denoting what the connection is for. */
88+ tr("Type"),
89+ /*: Title of Peers Table column which contains a value for
90+ the network the peer resides on. */
91+ tr("Network"),
92+ /*: Title of Peers Table column which contains a value for
93+ the latency of the connection established with the peer. */
94+ tr("Ping"),
95+ /*: Title of Peers Table column which contains a value for
96+ the total amount of bytes we have sent to the peer. */
98+ /*: Title of Peers Table column which contains a value for
99+ the total amount of bytes we have received from the peer. */
100+ tr("Received"),
101+ /*: Title of Peers Table column which contains the peer's
102+ User Agent string. A peer can configure this value to
103+ allow itself to be identifiable. */
-uacomment, maybe avoid this particular pattern to make the comment more general?
ACK b405f19c953d9cd5aa90b66001c31cc58230fb78, I agree on column title renaming, and as a translator I’m happy to see more translator comments.
I’m not an expert in the English Grammar, therefore, the following nits could be just ignored.
Adds Qt Translator Comments to each Peers Table column to aid translators by providing context.
updated from b405f19 -> 657b33e (pr311.03, pr311.04, diff)
Changes: Updated to address review comments on the translator comment contents, thanks @hebasto and @jonatack!
Here is a diff of how I’ve taken your suggestions and updated from pr311.03:
0diff --git a/src/qt/peertablemodel.h b/src/qt/peertablemodel.h
1index 268ae013e..3d195342f 100644
2--- a/src/qt/peertablemodel.h
3+++ b/src/qt/peertablemodel.h
4@@ -79,27 +79,25 @@ private:
5 unique number used to identify a connection. */
6 tr("Peer"),
7 /*: Title of Peers Table column which contains the
8- IP/Onion/I2P address we used to connect to the peer. */
9+ IP/Onion/I2P address of the connected peer. */
10 tr("Address"),
11- /*: Title of Peers Table column which contains a value for
12- the type of connection we have established with the peer.
13- Type is a term denoting what the connection is for. */
14+ /*: Title of Peers Table column which describes the type of
15+ peer connection. The "type" describes why the connection exists. */
16 tr("Type"),
17- /*: Title of Peers Table column which contains a value for
18- the network the peer resides on. */
19+ /*: Title of Peers Table column which states the network the peer
20+ connected through. */
21 tr("Network"),
22- /*: Title of Peers Table column which contains a value for
23- the latency of the connection established with the peer. */
24+ /*: Title of Peers Table column which indicates the current latency
25+ of the connection with the peer. */
26 tr("Ping"),
27- /*: Title of Peers Table column which contains a value for
28- the total amount of bytes we have sent to the peer. */
29+ /*: Title of Peers Table column which indicates the total amount of
30+ network information we have sent to the peer. */
31 tr("Sent"),
32- /*: Title of Peers Table column which contains a value for
33- the total amount of bytes we have received from the peer. */
34+ /*: Title of Peers Table column which indicates the total amount of
35+ network information we have received from the peer. */
36 tr("Received"),
37 /*: Title of Peers Table column which contains the peer's
38- User Agent string. A peer can configure this value to
39- allow itself to be identifiable. */
40+ User Agent string. */
41 tr("User Agent")};
42 std::unique_ptr<PeerTablePriv> priv;
43 QTimer *timer;