BitcoinDesign/Bitcoin-Icons Integration Discussion Tracker #314

issue jarolrod openend this issue on May 3, 2021
  1. jarolrod commented at 11:10 pm on May 3, 2021: member

    This is to track discussion and progress around integrating the icons being developed at BitcoinDesign/Bitcoin-Icons into the GUI.

    Current Status: Waiting for missing icons

    Rationale

    The integration of these icons is a nice-to-have facelift for the GUI. While here, we can introduce the use of Icon Themes. This is useful for aesthetic/accessibility reasons; the outlined theme as default, option to enable filled icon theme.

    This will be closed by a PR introducing these new icons.

    Note: This will focus on ensuring we have direct one-to-one swaps with the current icon set. This will not focus on new non-existent icons that we would like to use for a feature.

    Proposed Swaps

    Add Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    add add plus-filled

    Address Book Icon

    Current Status: Needs New Icon ❌

    Current New (Outlined) New (Filled)
    address-book

    Chevron Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    chevron console-outline console-filled

    Clock Icon

    Current Status: Needs variations created to be used for animation ❌

    Current New (Outlined) New (Filled)
    clock1 clock-outline clock-filled
    clock2
    clock3
    clock4
    clock5

    Connect Icon

    Current Status: Ready ✅

    Variations exist for animation

    Current New (Outlined) New (Filled)
    connect0 node-0 connections node-0 connections
    connect1 node-1 connection node-1 connection
    connect2 node-2 connections node-2 connections
    connect3 node-3 connections node-3 connections
    connect4 node node

    Edit Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    edit edit edit

    Edit Copy Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    editcopy copy copy

    Edit Paste Icon

    Current Status: Needs New Icon ❌

    Current New (Outlined) New (Filled)
    editpaste

    Export Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    export export export

    Eye Minus Icon

    Current Status: Needs New Icon ❌

    Current New (Outlined) New (Filled)
    eye_minus

    Eye Plus Icon

    Current Status: Needs New Icon ❌

    Current New (Outlined) New (Filled)
    eye_plus

    Eye Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    eye visible visible

    Font Bigger Icon

    Current Status: Needs New Icon ❌

    Current New (Outlined) New (Filled)
    fontbigger

    Font Smaller Icon

    Current Status: Needs New Icon ❌

    Current New (Outlined) New (Filled)
    fontsmaller

    HD Disabled Icon

    Current Status: Maybe 🤔

    Current New (Universal)
    hd_disabled two-keys copy

    HD Enabled Icon

    Current Status: Maybe 🤔

    Current New (Universal)
    hd_enabled two-keys

    History Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    history wallet wallet

    Lock Closed Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    lock_closed lock lock

    Lock Open Icon

    Current Status: Needs New Icon ❌

    Current New (Outlined) New (Filled)
    lock_open

    Network Disabled

    Current Status: Needs New Icon ❌

    Current New (Outlined) New (Filled)
    network_disabled

    Overview Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    overview home home

    Proxy Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    proxy proxy proxy

    Receive Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    receive receive receive

    Remove Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    remove clear-character clear-character

    Send Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    send send send

    Synced Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    synced check check

    Transaction Abandoned Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    transaction_abandoned trash trash

    Transaction Conflicted Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    transaction_conflicted cross cross

    Transaction 0 Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    transaction0 question question

    Transaction 2 Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    transaction2 check check

    Tx Inout Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    tx_inout transfer transfer

    Tx Input Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    tx_input receive receive

    Tx Mined Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    tx_mined mining mining

    Tx Output Icon

    Current Status: Ready ✅

    Current New (Outlined) New (Filled)
    tx_output send copy send

    Warning Icon

    Current Status: Needs New Icon ❌

    Current New (Outlined) New (Filled)
    warning

    Pinging @bosch-0 @GBKS

  2. jarolrod commented at 3:53 am on May 4, 2021: member
    Currently not convinced that the proposed replacements HD icons are a good fit.
  3. GBKS commented at 6:55 am on May 6, 2021: none

    Thanks for the summary, this is great. Would it be possible to add another table column with the use/purpose of each icon? For example, I am not sure what the eye plus/minus ones are used for. From talking to @Bosch-0, it also sounds like the HD icon is not quite accurate in that it’s used to indicate a (non-)blank wallet, and the eye icon being used to indicate that the private key is disabled. There might be different visual metaphors that communicate these things more clearly, so starting with the purpose of each icon would be helpful.

    Do we need to differentiate between copy and paste icons or could those be the same? If we need two, then it would be ideal if they looked similar (like font bigger and smaller are similar)

  4. hebasto added the label Design on May 8, 2021
  5. eazydripz commented at 8:48 am on June 3, 2021: none
    Thank you.
  6. Rspigler commented at 4:50 am on June 9, 2021: contributor

    I really like these. Not sure how future proof the Proxy icon is with a possible Tor/I2P icon (or how network icons will really even work with multiple privacy networks honestly, but thought I should bring it up).

    I’m not sure how I feel about the Send/Receive being the same as the TxOut/In

    Otherwise, awesome!

  7. Bosch-0 commented at 2:09 am on June 22, 2021: none

    For simplicity we should stick with just using the filled style. Outline style’s can be reserved for other states such as an ‘disabled’ state.

    Extra icons to add to this list:

    • Disabled private keys - currently a lower opacity eye icon is used, the outline two key icon could be used for inactive state and filled for active.

    Can you even create a HD disabled keys with the GUI? If not we should just remove the HD and HD disabled icons as they do not add any benefit.

    Do we need an icon to show that the wallet is a descriptor wallet?

  8. Rspigler commented at 5:34 pm on June 22, 2021: contributor
    I feel like the outline style is a more modern/fresh look compared to the filled style (although you guys are the designers). Using the outline style as a disabled state I feel would be confusing.
  9. jarolrod commented at 5:34 am on October 26, 2021: member
    Closing as I will no longer be working on a patch set for new icons in this repo. bitcoin-core/gui-qml will use the bitcoindesign icons.
  10. jarolrod closed this on Oct 26, 2021
  11. bitcoin-core locked this on Oct 26, 2022


jarolrod GBKS eazydripz Rspigler Bosch-0

Labels
Design

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 13:20 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me