Add `Copy address` Peers Tab Context Menu Action #318

pull jarolrod wants to merge 1 commits into bitcoin-core:master from jarolrod:copy-addr-peer changing 1 files +5 −0

jarolrod commented at 9:03 AM on May 5, 2021: member

Picking up #264

This adds a Copy Address context menu action to the Peers Tab.

Based on the first commit of PR #317 so that we can use Qt::DisplayRole in the copyEntryData function.

Master PR
hebasto added the label UX on May 9, 2021
promag commented at 1:38 PM on May 10, 2021: contributor

Concept ACK. But I'm not fond of the base commit "gui: add Direction column to peers tab" - I understand it simplifies this change.
jarolrod force-pushed on May 26, 2021
jarolrod commented at 4:22 AM on May 26, 2021: member
updated from 6ee6d2f -> d6099b7 (pr318.01, pr318.02, diff)
- rebase on top of updated last commit of #317
- add translator comment for Copy address action
DrahtBot added the label Needs rebase on May 26, 2021
jarolrod force-pushed on May 26, 2021
jarolrod commented at 8:44 PM on May 26, 2021: member
updated from d6099b7 -> 85e0f95 (pr318.02 -> pr318.03)

Changes:
- Rebased over master because of conflict with #313 (because this is based on #317)
jarolrod force-pushed on May 26, 2021
jarolrod commented at 10:38 PM on May 26, 2021: member
updated from 85e0f95 -> 65d1d35 (pr318.03 -> pr318.04, diff)
- rebased to solve conflict with #311 (because this is based on #317)
DrahtBot removed the label Needs rebase on May 27, 2021

in src/qt/rpcconsole.cpp:651 in 65d1d35178 outdated

 646 | @@ -647,6 +647,11 @@ void RPCConsole::setClientModel(ClientModel *model, int bestblock_height, int64_
 647 |  
 648 |          // create peer table context menu
 649 |          peersTableContextMenu = new QMenu(this);
 650 | +        //: Context menu action to copy the address of a peer
 651 | +        peersTableContextMenu->addAction(tr("Copy address"), [this] {

luke-jr commented at 9:01 PM on June 12, 2021:

Please add a keyboard shortcut (&C used elsewhere)

jarolrod commented at 7:52 PM on September 5, 2021:

Thanks, updated

bitcoin-core deleted a comment on Jun 14, 2021
bitcoin-core deleted a comment on Jun 14, 2021
DrahtBot added the label Needs rebase on Jun 14, 2021
promag commented at 10:41 AM on September 5, 2021: contributor

@jarolrod needs rebase, this is a cool change.
jonatack commented at 11:07 AM on September 5, 2021: contributor

Concept ACK
qt: Add "Copy address" item to the context menu in the Peers table
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
3ec061d9da
jarolrod force-pushed on Sep 5, 2021
jarolrod commented at 7:52 PM on September 5, 2021: member
updated from 65d1d35 -> 3ec061d (pr318.04 -> pr318.05)

Changes:
- rebased over recent changes
- Dropped commit from #317 as it was merged
- addressed @luke-jr comments and added a mnemonic shortcut
DrahtBot removed the label Needs rebase on Sep 5, 2021
shaavan approved
shaavan commented at 3:14 PM on September 10, 2021: contributor

tACK 3ec061d9da0c8742bd9dec94ffeb82a11d000aba Tested on Ubuntu 20.04 (Using Qt version 5.12.8)

This PR adds the functionality to copy the address of a peer from the peertable itself. Tested this PR on Ubuntu 20.04. And I was able to observe the change working correctly.

Master PR

I agree with the changes suggested in this PR. After #384 being merged, I think it is the next logical step to also having the functionality of copying the address of peer from peertable using the context menu action.

<p>
luke-jr approved
luke-jr commented at 5:11 PM on September 11, 2021: member

utACK 3ec061d9da0c8742bd9dec94ffeb82a11d000aba

in src/qt/rpcconsole.cpp:683 in 3ec061d9da

 679 | @@ -680,6 +680,11 @@ void RPCConsole::setClientModel(ClientModel *model, int bestblock_height, int64_
 680 |  
 681 |          // create peer table context menu
 682 |          peersTableContextMenu = new QMenu(this);
 683 | +        //: Context menu action to copy the address of a peer

hebasto commented at 3:51 PM on September 12, 2021:

nit:

        //: Context menu action to copy the address of a peer.

hebasto approved
hebasto commented at 3:58 PM on September 12, 2021: member

ACK 3ec061d9da0c8742bd9dec94ffeb82a11d000aba, tested on Linux Mint 20.2 (Qt 5.12.8):
hebasto merged this on Sep 12, 2021
hebasto closed this on Sep 12, 2021
jonatack commented at 4:19 PM on September 12, 2021: contributor

Nice and useful change!
sidhujag referenced this in commit 19600c3a64 on Sep 13, 2021
hebasto referenced this in commit 2161a05855 on Sep 14, 2021
sidhujag referenced this in commit e5c2a8a01a on Sep 15, 2021
bitcoin-core locked this on Sep 15, 2022

Contributors

Labels

Linked (view graph)

#264 Add "Copy address" item to the context menu in the Peers table #317 Add Direction column to Peers Tab #420 Ensure translator comments end in full stop