English translations update #323

1. 
   laanwj commented at 12:05 pm on May 10, 2021: member

   Update for Transifex. Needed after bitcoin/bitcoin#21836.
2. laanwj added the label Translations on May 10, 2021
3. in src/qt/bitcoinstrings.cpp:15 in 99e98084fc outdated

    9@@ -10,239 +10,4 @@
   10 #endif
   11 static const char UNUSED *bitcoin_strings[] = {
   12 QT_TRANSLATE_NOOP("bitcoin-core", "The %s developers"),
   13-QT_TRANSLATE_NOOP("bitcoin-core", ""
   14-"%s corrupt. Try using the wallet tool bitcoin-wallet to salvage or restoring "
   15-"a backup."),
   

   ---

   ---

   

   hebasto commented at 1:12 pm on May 10, 2021:

   Changes in src/qt/bitcoinstrings.cpp look weird as, for example, this string still exists: https://github.com/bitcoin-core/gui/blob/99e98084fc528acdca9deae5b84f933a9235caca/src/wallet/bdb.cpp#L277

   ---

   

   laanwj commented at 9:46 am on May 11, 2021:

   Do you get the same result if you run make translate in src? Trying to figure out if I’m doing something wrong here or the scripting is broken.

   ---

   

   hebasto commented at 9:59 am on May 11, 2021:

   Yeah, the same.

   The following diff fixes it:

    0--- a/share/qt/extract_strings_qt.py
    1+++ b/share/qt/extract_strings_qt.py
    2@@ -58,7 +58,7 @@ if not XGETTEXT:
    3     print('Cannot extract strings: xgettext utility is not installed or not configured.',file=sys.stderr)
    4     print('Please install package "gettext" and re-run \'./configure\'.',file=sys.stderr)
    5     sys.exit(1)
    6-child = Popen([XGETTEXT,'--output=-','-n','--keyword=_'] + files, stdout=PIPE)
    7+child = Popen([XGETTEXT,'--output=-','--from-code=utf-8','-n','--keyword=_'] + files, stdout=PIPE)
    8 (out, err) = child.communicate()
    9 
   10 messages = parse_po(out.decode('utf-8'))
   

   Details: https://bugzilla.redhat.com/show_bug.cgi?id=237786

   UPDATE: Is it ok for such change to be a part of a translation update pr?

4. 
   hebasto commented at 10:03 am on May 11, 2021: member

   @laanwj

   If this PR will be updated, could you rebase it to include the recent changes from #296?

5. qt: Extract translations correctly from UTF-8 formatted source 55c012d20c
6. qt: English translations update

   Update for Transifex. Needed after bitcoin/bitcoin#21836.

   c34a49f77f
7. laanwj force-pushed on May 17, 2021
8. 
   laanwj commented at 11:47 am on May 17, 2021: member

   Updated.

   (I only just noticed I made this branch to the gui repository itself instead of my fork. Sorry for that. Will take care to delete it after merge.)

9. hebasto approved
10. 
    hebasto commented at 12:28 pm on May 17, 2021: member

    ACK c34a49f77f474c94e005331458111308a19afd53, verified that make -C src translate returns zero updated strings (as all of them are updated in the top commit):

    0...
    1Updating 'qt/locale/bitcoin_en.ts'...
    2    Found 1048 source text(s) (0 new and 1048 already existing)
    3...
    

11. hebasto renamed this:
    qt: English translations update
    English translations update
    on May 17, 2021
12. hebasto merged this on May 17, 2021
13. hebasto closed this on May 17, 2021

    ---

14. laanwj deleted the branch on May 17, 2021
15. sidhujag referenced this in commit 902f9e8bb1 on May 17, 2021
16. gwillen referenced this in commit 9f4f65bbbe on Jun 1, 2022
17. bitcoin-core locked this on Aug 16, 2022

Contributors
laanwj hebasto

Labels
Translations