English translations update #346

pull hebasto wants to merge 2 commits into bitcoin-core:master from hebasto:210527-tr changing 5 files +1201 −1212

hebasto commented at 10:32 AM on May 27, 2021: member

Update for Transifex.

After changing translator comments in #332 this update will show if Transifex triggers strings to be re-translated.
in src/qt/bitcoinstrings.cpp:186 in ed36290725 outdated
```
 182 | @@ -189,7 +183,7 @@ QT_TRANSLATE_NOOP("bitcoin-core", "Invalid netmask specified in -whitelist: '%s'
 183 |  QT_TRANSLATE_NOOP("bitcoin-core", "Loading P2P addresses…"),
 184 |  QT_TRANSLATE_NOOP("bitcoin-core", "Loading banlist…"),
 185 |  QT_TRANSLATE_NOOP("bitcoin-core", "Loading block index…"),
 186 | -QT_TRANSLATE_NOOP("bitcoin-core", "Loading wallet…"),
 187 | +QT_TRANSLATE_NOOP("bitcoin-core", "Loading wallet..."),
```
laanwj commented at 10:33 AM on May 27, 2021:

Strange, why is this changing back

laanwj commented at 10:35 AM on May 27, 2021:

Looks like bitcoin/bitcoin#20773 accidentally reverted this

hebasto commented at 10:38 AM on May 27, 2021:

yeah...

don't throw a stone at me, but a linter could help

laanwj commented at 10:40 AM on May 27, 2021:

Please no…

hebasto commented at 10:52 AM on May 27, 2021:

Fixed in the recent push.

scripted-diff: Fix ellipsis after pr20773

-BEGIN VERIFY SCRIPT-
sed -i 's|_("Loading wallet...")|_("Loading wallet…")|' src/wallet/*.cpp
-END VERIFY SCRIPT-

bfb53ddda9

English translations update df4c81fda4

in src/qt/bitcoinstrings.cpp:78 in ed36290725 outdated

  74 | @@ -75,12 +75,6 @@ QT_TRANSLATE_NOOP("bitcoin-core", ""
  75 |  "Prune: last wallet synchronisation goes beyond pruned data. You need to -"
  76 |  "reindex (download the whole blockchain again in case of pruned node)"),
  77 |  QT_TRANSLATE_NOOP("bitcoin-core", ""
  78 | -"SQLiteDatabase: Failed to prepare the statement to fetch sqlite wallet "

laanwj commented at 10:36 AM on May 27, 2021:

Nice, this definitely doesn't need to be translated.

hebasto force-pushed on May 27, 2021
laanwj commented at 10:58 AM on May 27, 2021: member

ACK df4c81fda490e556775f6006f3d4f7d54f61073b make translate gives me an empty diff
jarolrod commented at 12:21 PM on May 27, 2021: member

ACK df4c81fda490e556775f6006f3d4f7d54f61073b

Also get an empty diff after running make -C src translate.
hebasto merged this on May 27, 2021
hebasto closed this on May 27, 2021
hebasto deleted the branch on May 27, 2021
hebasto added the label Translations on May 27, 2021
sidhujag referenced this in commit e627fe456b on May 27, 2021
hebasto commented at 5:42 PM on May 27, 2021: member
The results of this testing PR.

In case of changing of translator comments, Transifex:
- does not change the "Translated" status of the translated string
- drops the "Reviewed" status of the translated string
ryanofsky cross-referenced this on Jun 7, 2021 from issue refactor: remove ::vpwallets and related global variables by ryanofsky
gwillen referenced this in commit 013eaeaca2 on Jun 1, 2022
bitcoin-core locked this on Aug 16, 2023

Contributors

Labels

Linked (view graph)

#332 Replace disambiguation strings with translator comments

English translations update #346

The results of this testing PR.