Deprecation warnings when building against Qt 5.15

fanquake commented at 4:04 am on July 17, 2020: member

For a while there’s been a stack of Qt related warnings when building against Qt 5.15. Someone might want to take a stab at cleaning them up, assuming we can keep the code backwards compatible, without using too many hacks. There may be more than this, but these are all of the unique ones I could see:

0  CXX      qt/libbitcoinqt_a-modaloverlay.o
1qt/bitcoin.cpp:259:53: warning: 'QFlags' is deprecated: Use default constructor instead [-Wdeprecated-declarations]
2    SplashScreen *splash = new SplashScreen(m_node, nullptr, networkStyle);
3                                                    ^
4/usr/local/Cellar/qt/5.15.0/lib/QtCore.framework/Headers/qflags.h:123:5: note: 'QFlags' has been explicitly marked deprecated here
5    QT_DEPRECATED_X("Use default constructor instead") Q_DECL_CONSTEXPR inline QFlags(Zero) noexcept : i(0) {}

0  CXX      qt/libbitcoinqt_a-peertablemodel.o
1qt/bitcoingui.cpp:1308:29: warning: 'pixmap' is deprecated: Use the other overload which returns QPixmap by-value [-Wdeprecated-declarations]
2        if (labelProxyIcon->pixmap() == nullptr) {
3                            ^
4/usr/local/Cellar/qt/5.15.0/lib/QtWidgets.framework/Headers/qlabel.h:77:5: note: 'pixmap' has been explicitly marked deprecated here
5    QT_DEPRECATED_VERSION_X(5, 15, "Use the other overload which returns QPixmap by-value")

0  CXX      qt/libbitcoinqt_a-coincontroltreewidget.o
1qt/optionsmodel.cpp:222:59: warning: 'split' is deprecated: Use Qt::SplitBehavior variant instead [-Wdeprecated-declarations]
2    QStringList ip_port = settings.value(name).toString().split(":", QString::SkipEmptyParts);
3                                                          ^
4/usr/local/Cellar/qt/5.15.0/lib/QtCore.framework/Headers/qstring.h:603:23: note: 'split' has been explicitly marked deprecated here
5    Q_REQUIRED_RESULT QT_DEPRECATED_VERSION_X_5_15("Use Qt::SplitBehavior variant instead")

0qt/transactionview.cpp:278:17: warning: 'QDateTime' is deprecated: Use QDate::startOfDay() [-Wdeprecated-declarations]
1                QDateTime(current),
2                ^
3/usr/local/Cellar/qt/5.15.0/lib/QtCore.framework/Headers/qdatetime.h:296:5: note: 'QDateTime' has been explicitly marked deprecated here
4    QT_DEPRECATED_X("Use QDate::startOfDay()") explicit QDateTime(const QDate &);

0  CXX      qt/libbitcoinqt_a-moc_bitcoinaddressvalidator.o
1qt/sendcoinsdialog.cpp:174:72: warning: 'buttonClicked' is deprecated: Use QButtonGroup::idClicked(int) instead [-Wdeprecated-declarations]
2        connect(ui->groupFee, static_cast<void (QButtonGroup::*)(int)>(&QButtonGroup::buttonClicked), this, &SendCoinsDialog::updateFeeSectionControls);
3                                                                       ^
4/usr/local/Cellar/qt/5.15.0/lib/QtWidgets.framework/Headers/qbuttongroup.h:89:5: note: 'buttonClicked' has been explicitly marked deprecated here
5    QT_DEPRECATED_VERSION_X_5_15("Use QButtonGroup::idClicked(int) instead")

fanquake added the label good first issue on Jul 17, 2020

Sjors commented at 12:31 pm on August 28, 2020: member

I don’t see these on macOS when building against homebrew QT 5.15.0 (configured with --enable-werror --enable-debug)

hebasto commented at 1:19 pm on August 28, 2020: member

Do you use Apple’s compiler or llvm’s one?

On Fri, 28 Aug 2020 at 15:32, Sjors Provoost notifications@github.com wrote:

I don’t see these on macOS when building against homebrew QT 5.15.0 (configured with –enable-werror –enable-debug)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/issues/36#issuecomment-682499533, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3PXPXE6KRH4DJVZDKG2VTSC6PUXANCNFSM4O5OXLMQ .

–

– Hennadii Stepanov

Sjors commented at 3:29 pm on August 28, 2020: member

The default, so probably Apple’s

hebasto commented at 3:57 pm on August 28, 2020: member

@Sjors

Having:

macOS 10.15.6 (19G2021)
Apple’s clang (default)

0$ clang --version
1Apple clang version 11.0.3 (clang-1103.0.32.29)
2Target: x86_64-apple-darwin19.6.0
3Thread model: posix
4InstalledDir: /Library/Developer/CommandLineTools/usr/bin

brew’s Qt 5.15.0

… and loads of warnings.

Sjors commented at 4:54 pm on August 28, 2020: member

0clang --version
1Apple clang version 11.0.3 (clang-1103.0.32.62)
2Target: x86_64-apple-darwin19.6.0
3Thread model: posix
4InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

promag commented at 10:26 am on September 25, 2020: contributor

Same as @hebasto.

MarcoFalke closed this on Nov 19, 2020

bitcoin-core locked this on Feb 15, 2022

Deprecation warnings when building against Qt 5.15 #36