Dark Mode fixes/portability #366

1. 
   luke-jr commented at 7:27 pm on June 22, 2021: member

   The changes to support macOS “Dark Mode” are valid for any platform, and should work so long as Qt implements the PaletteChange event. (Worst case, we’re no worse off with trying.)

   Additionally, we shouldn’t block the parent classes from implementing event handlers. Who knows what side effects that could have.

2. GUI: Enable palette change adaptation on all platforms c901d4d8ce
3. GUI: Always call parent changeEvent handler 9d5bf6bf01
4. hebasto added the label UI on Jun 22, 2021
5. 
   hebasto commented at 11:46 pm on June 22, 2021: member

   … we shouldn’t block the parent classes from implementing event handlers. Who knows what side effects that could have.

   Looks reasonable.

6. bitcoin-core deleted a comment on Jun 23, 2021
7. 
   jonatack commented at 11:20 am on June 23, 2021: contributor

   Concept ACK. Lightly tested, debug build is clean. I have my system set up (on Debian testing) so the GUI follows my system settings, and this change doesn’t affect it; everything looks the same for me.
8. bitcoin-core deleted a comment on Jun 24, 2021
9. hebasto approved
10. 
    hebasto commented at 4:27 am on June 29, 2021: member

    ACK 9d5bf6bf01af40a9684f1b1f06a8df4aaf36b8f3, tested on Linux Mint 20.1 (Qt 5.12.8) with the qt5ct package installed.
11. hebasto added this to the milestone 22.0 on Jun 29, 2021
12. kristapsk approved
13. 
    kristapsk commented at 11:01 pm on June 30, 2021: contributor

    ACK 9d5bf6bf01af40a9684f1b1f06a8df4aaf36b8f3. Tested on Gentoo Linux with Xfce4 and Qt 5.15.2, does not break anything on my computer.
14. hebasto merged this on Jul 1, 2021
15. hebasto closed this on Jul 1, 2021

    ---

16. sidhujag referenced this in commit 814202a9fa on Jul 1, 2021
17. gwillen referenced this in commit bccdd19229 on Jun 1, 2022
18. bitcoin-core locked this on Aug 16, 2022

Contributors
luke-jr hebasto jonatack kristapsk

Labels
UI

Milestone
22.0