Emit dataChanged signal to dynamically re-sort Peers table #375

1. 
   hebasto commented at 2:38 pm on June 28, 2021: member

   By default, the PeerTableSortProxy

   dynamically re-sorts … data whenever the original model changes.

   That is not the case on master (8cdf91735f2bdc55577d84a9915f5920ce23b00a) as in ecbd91153875c8cdd5b92b840afc116f65e457fb (#164) no signals are emitted to notify about model changes.

   This PR uses a dedicated dataChanged signal.

   Fixes #367.

   An alternative to #374.

2. qt: Emit dataChanged signal to dynamically re-sort Peers table 986bf78d7e
3. 
   hebasto commented at 2:47 pm on June 28, 2021: member

   @rebroad Do you mind testing this PR?
4. hebasto added the label Bug on Jun 28, 2021
5. hebasto added the label UI on Jun 28, 2021
6. 
   jarolrod commented at 2:23 am on June 29, 2021: member

   ACK 986bf78d7e8fd9b69841ecb0decaff840efe9cff

   Tested on Arch Linux, Ubuntu, macOS 11.3, and Windows 10. The usage of dataChanged here is correct and solves the mentioned issue.

   The following screenshots will compare the behavior of master and this PR. Note that the screenshots will sort by Received.

   On the master screenshots you will see the ordering get out of whack because it is not dynamically sorting the peers as the data changes.

   On the PR screenshots, you will see that the ordering is correct because we now allow to dynamically sort the peers as the data changes.

   Ubuntu

   Master	PR

   macOS

   Master	PR

   Windows 10

   Master	PR

7. hebasto added this to the milestone 22.0 on Jun 29, 2021
8. hebasto merged this on Jul 5, 2021
9. hebasto closed this on Jul 5, 2021

   ---

10. hebasto deleted the branch on Jul 5, 2021
11. sidhujag referenced this in commit 5a94dda3de on Jul 5, 2021
12. gwillen referenced this in commit 589d505c6b on Jun 1, 2022
13. bitcoin-core locked this on Aug 16, 2022

Contributors
hebasto jarolrod

Labels
Bug UI

Milestone
22.0