Add ability to integrate the client with desktop environment on Linux #38

pull hebasto wants to merge 3 commits into bitcoin-core:master from hebasto:200720-desktop changing 20 files +519 −350
  1. hebasto commented at 3:43 pm on July 20, 2020: member

    On Linux a new menu item “Settings” –> “Integrate with desktop environment” is available now (non-regtest only).

    Here are some screenshots:

    Screenshot from 2020-07-20 18-36-52

    DeepinScreenshot_select-area_20200720190707

    Screenshot from 2020-07-20 18-41-08

    Closes #31

    Localization of the *.desktop files is out of this PR scope.

  2. jonatack commented at 3:58 pm on July 20, 2020: contributor
    Concept ACK
  3. hebasto force-pushed on Jul 20, 2020
  4. hebasto commented at 4:11 pm on July 20, 2020: member

    Updated 2bd1394dce8cbe50a82c1e11aeb1edba6feabebb -> 5dc09b5526a28c92f6b8640fc5234ff3a93a0ee3 (pr38.01 -> pr38.02, diff):

    • improved user-faced “Comment” field
    • screenshot in the OP has been updated
  5. luke-jr commented at 4:30 pm on July 20, 2020: member
    Approach NACK. Just restore the .desktop file removed in fa0e1e2f630e6ca6cdfca64d8d92a7f0f85baa4d and add the missing bits to configure.ac. There’s no reason to go through the application to generate this…
  6. caiofaustino commented at 10:51 pm on July 20, 2020: none
    Tested, works well for me. File created at ~/.local/share/applications/org.bitcoincore.BitcoinQt.desktop Screenshot from 2020-07-21 00-44-20
  7. caiofaustino commented at 11:02 pm on July 20, 2020: none

    Approach NACK. Just restore the .desktop file removed in fa0e1e2 and add the missing bits to configure.ac. There’s no reason to go through the application to generate this…

    Can you explain what behaviour that approach would have for a user downloading the binary from the website? I’m new to most of this, my understanding was that configure.ac. only affected compilation.

  8. luke-jr commented at 2:15 am on July 21, 2020: member

    Can you explain what behaviour that approach would have for a user downloading the binary from the website?

    There’d presumably be a .desktop file in the tarball they could install to the right place.

  9. caiofaustino commented at 6:41 am on July 21, 2020: none

    There’d presumably be a .desktop file in the tarball they could install to the right place.

    Thanks for the explanation, yeah that could be an alternative, although I think this one is more user friendly, I’m not sure what level of technical expertise is expected from the users.

  10. hebasto commented at 4:29 pm on July 29, 2020: member

    Approach NACK. Just restore the .desktop file removed in fa0e1e2 and add the missing bits to configure.ac. There’s no reason to go through the application to generate this…

    Can you explain what behaviour that approach would have for a user downloading the binary from the website?

    There’d presumably be a .desktop file in the tarball they could install to the right place.

    Placing a *.desktop file into the tarball requires placing icon files into it as well.

    Manually installing a *.desktop and icon files seems not user-friendly.

    As a *.desktop and icon files usually are parts of packages (e.g., https://snapcraft.io/bitcoin-core, https://packages.debian.org/sid/main/bitcoin-qt), it is possible that a configure option is required to disable this feature for package maintainers. @MarcoFalke What do you think about it?

  11. luke-jr commented at 7:38 pm on July 29, 2020: member
    Packagers would simply switch to the bundled icon/desktop files…
  12. hebasto commented at 8:13 pm on July 29, 2020: member

    Packagers would simply switch to the bundled icon/desktop files…

    Yes, that is what I mean: if icon/desktop files are bundled into the package there is no need to compile the feature introduced in this PR; therefore it could be disabled by the configure script.

  13. hebasto commented at 7:14 am on August 4, 2020: member

    Approach NACK. Just restore the .desktop file removed in fa0e1e2 and add the missing bits to configure.ac. There’s no reason to go through the application to generate this…

    The alternative approach is https://github.com/bitcoin/bitcoin/pull/15068

  14. DrahtBot added the label Needs rebase on Aug 25, 2020
  15. qt, util: Split out qt/guifileutil module 0af424533f
  16. qt, util: Refactor out GetExecutablePathAsString() function f14ca7d1dd
  17. qt: Add Settings -> Integrate... menu item 95c0cff67f
  18. hebasto force-pushed on Aug 26, 2020
  19. hebasto commented at 6:13 pm on August 26, 2020: member
    Rebased 5dc09b5526a28c92f6b8640fc5234ff3a93a0ee3 -> 95c0cff67f98aa1798cc1b0e9fd39fa33bd4dbe5 (pr38.02 -> pr38.03) due to the conflict with https://github.com/bitcoin/bitcoin/pull/15704.
  20. DrahtBot removed the label Needs rebase on Aug 26, 2020
  21. jarolrod approved
  22. jarolrod commented at 8:18 am on December 4, 2020: member

    Tested ACK on Arch Linux and KDE Plasma. Works smoothly. Also tested to make sure this option doesn’t show up on macOS.

    One question: the option does not show up when testing on FreeBSD, how do we add support for the BSD’s?

  23. hebasto commented at 10:10 am on December 4, 2020: member

    @jarolrod

    Tested ACK on Arch Linux and KDE Plasma. Works smoothly. Also tested to make sure this option doesn’t show up on macOS.

    Thank you for testing.

    One question: the option does not show up when testing on FreeBSD, how do we add support for the BSD’s?

    I’m not familiar with BSD world, except of macOS :)

  24. DrahtBot commented at 11:02 pm on December 28, 2020: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

  25. DrahtBot added the label Needs rebase on Dec 28, 2020
  26. hebasto marked this as a draft on Dec 30, 2020
  27. hebasto commented at 8:24 pm on April 30, 2021: member
    Closing and leaving it up for grabs.
  28. hebasto closed this on Apr 30, 2021
  29. hebasto removed the label Needs rebase on Apr 30, 2021
  30. hebasto added the label Feature on Apr 30, 2021
  31. hebasto added the label Linux on Apr 30, 2021
  32. hebasto added the label up for grabs on Apr 30, 2021
  33. caiofaustino commented at 6:56 pm on May 1, 2021: none
    What does leaving for grabs mean? Is this feature still considered or does it need further discussion?
  34. hebasto commented at 7:12 pm on May 1, 2021: member

    What does leaving for grabs mean? Is this feature still considered or does it need further discussion?

    Anyone could continue this work. Although, a new pr will be a subject for discussion.

  35. bitcoin-core locked this on Aug 16, 2022


hebasto jonatack luke-jr caiofaustino jarolrod DrahtBot

Labels
Feature Up for grabs Linux

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-23 00:20 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me