Always log context function of QtDebugMsg messages #385

pull promag wants to merge 1 commits into bitcoin-core:master from promag:2021-07-qdebug-func changing 3 files +10 −11
  1. promag commented at 10:57 am on July 22, 2021: contributor
    Use QMessageLogContext::function consistently for all qDebug calls instead of explicitly logging __func__ in some places.
  2. qt: Always log context function of QtDebugMsg messages 753c182794
  3. hebasto added the label Refactoring on Jul 22, 2021
  4. hebasto commented at 3:47 pm on July 22, 2021: member

    The diff of last lines of logs for master and this pr with -debug=qt -nologtimestamps:

    0 [shutoff] Shutdown: done
    1-[shutoff] GUI: shutdown : Shutdown finished
    2-[main] GUI: ~InitExecutor : Stopping thread
    3-[main] GUI: ~InitExecutor : Stopped thread
    4+[shutoff] GUI: void InitExecutor::shutdown(): Shutdown finished
    5+[main] GUI: virtual InitExecutor::~InitExecutor(): Stopping thread
    6+[main] GUI: virtual InitExecutor::~InitExecutor(): Stopped thread
    

    The output is more verbose.

    What are benefits of this change?

    Why InitExecutor::~InitExecutor() destructor is virtual?

  5. hebasto commented at 4:01 pm on July 22, 2021: member
    Update messages in qWarning() calls?
  6. hebasto commented at 10:32 am on July 23, 2021: member
    How is this feature combined with -logsourcelocations command-line option?
  7. hebasto renamed this:
    qt: Always log context function of QtDebugMsg messages
    Always log context function of QtDebugMsg messages
    on Aug 4, 2021
  8. promag commented at 10:52 am on September 5, 2021: contributor

    What are benefits of this change?

    The idea is to clean up a bit (remove func) and make logging consistent.

    Why InitExecutor::~InitExecutor() destructor is virtual?

    Because base class has a virtual destructor?

    How is this feature combined with -logsourcelocations command-line option?

    Didn’t test, will check.

  9. DrahtBot added the label Needs rebase on Sep 28, 2021
  10. DrahtBot commented at 10:05 pm on September 28, 2021: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

  11. hebasto added the label Waiting for author on Sep 29, 2021
  12. promag closed this on Jan 13, 2022

  13. promag deleted the branch on Jan 13, 2022
  14. bitcoin-core locked this on Jan 13, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-22 02:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me