Use QMessageLogContext::function consistently for all qDebug calls instead of explicitly logging __func__ in some places.
Always log context function of QtDebugMsg messages #385
pull promag wants to merge 1 commits into bitcoin-core:master from promag:2021-07-qdebug-func changing 3 files +10 −11-
promag commented at 10:57 AM on July 22, 2021: contributor
-
qt: Always log context function of QtDebugMsg messages 753c182794
- hebasto added the label Refactoring on Jul 22, 2021
-
hebasto commented at 3:47 PM on July 22, 2021: member
The diff of last lines of logs for master and this pr with
-debug=qt -nologtimestamps:[shutoff] Shutdown: done -[shutoff] GUI: shutdown : Shutdown finished -[main] GUI: ~InitExecutor : Stopping thread -[main] GUI: ~InitExecutor : Stopped thread +[shutoff] GUI: void InitExecutor::shutdown(): Shutdown finished +[main] GUI: virtual InitExecutor::~InitExecutor(): Stopping thread +[main] GUI: virtual InitExecutor::~InitExecutor(): Stopped threadThe output is more verbose.
What are benefits of this change?
Why
InitExecutor::~InitExecutor()destructor isvirtual? -
hebasto commented at 4:01 PM on July 22, 2021: member
Update messages in
qWarning()calls? -
hebasto commented at 10:32 AM on July 23, 2021: member
How is this feature combined with
-logsourcelocationscommand-line option? - hebasto renamed this:
qt: Always log context function of QtDebugMsg messages
Always log context function of QtDebugMsg messages
on Aug 4, 2021 -
promag commented at 10:52 AM on September 5, 2021: contributor
What are benefits of this change?
The idea is to clean up a bit (remove func) and make logging consistent.
Why
InitExecutor::~InitExecutor()destructor isvirtual?Because base class has a virtual destructor?
How is this feature combined with
-logsourcelocationscommand-line option?Didn't test, will check.
- DrahtBot added the label Needs rebase on Sep 28, 2021
-
DrahtBot commented at 10:05 PM on September 28, 2021: contributor
<!--cf906140f33d8803c4a75a2196329ecb-->
🐙 This pull request conflicts with the target branch and needs rebase.
<sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>
- hebasto added the label Waiting for author on Sep 29, 2021
- promag closed this on Jan 13, 2022
- promag deleted the branch on Jan 13, 2022
- bitcoin-core locked this on Jan 13, 2023
