Add visual accenting for the 'Create new receiving address' button #39

pull hebasto wants to merge 2 commits into bitcoin-core:master from hebasto:200721-prim changing 3 files +6 −19

hebasto commented at 6:36 PM on July 21, 2020: member
Fix #24

The first commit:
- visual improvement with no behavior change
The second commit:
- removes a bunch of LOCs
- slightly change behavior and makes it standard
With this PR:

qt: Make "Create new receiving address" default unconditionally

This change makes this button visually accented, and gives to users a
hint about the primary action.
This commit does not change behavior.

4227a8e1f3

qt: Leverage the default "Create new receiving address" button

When Enter or Return is pressed the default button will be always
clicked. All buttons can always be clicked from the keyboard by pressing
spacebar when the button has focus.

4ec49f8d1e

Saibato commented at 12:43 PM on July 23, 2020: contributor

Concept tACK https://github.com/bitcoin-core/gui/pull/39/commits/4227a8e1f3a4f94a5a4cb7adeecf967e14156bde https://github.com/bitcoin-core/gui/pull/39/commits/4ec49f8d1e25b330e6a0f79ae897d98d29ff32f9

While testing this, at first my intuition was to click the bottom down menu, but there we have no create address. When i locked closer, i wondered if we could change the bottom down text for show addresses.

from From Receiving addresses to Show all receiving addresses ? To indicate that we do not create there new addresses
promag commented at 12:16 AM on July 27, 2020: contributor

Tested ACK 4ec49f8d1e25b330e6a0f79ae897d98d29ff32f9 on macos.
in src/qt/forms/receivecoinsdialog.ui:119 in 4ec49f8d1e
```
 113 | @@ -114,6 +114,12 @@
 114 |               <iconset resource="../bitcoin.qrc">
 115 |                <normaloff>:/icons/receiving_addresses</normaloff>:/icons/receiving_addresses</iconset>
 116 |              </property>
 117 | +            <property name="autoDefault">
 118 | +             <bool>false</bool>
 119 | +            </property>
```
luke-jr commented at 9:49 PM on July 31, 2020:

I don't think we need to mess with this?

hebasto commented at 10:25 AM on August 1, 2020:

This change is required.

From Qt docs:

autoDefault : bool ... This property's default is true for buttons that have a QDialog parent; otherwise it defaults to false.

As ReceiveCoinsDialog is derived from QDialog its buttons have autoDefault == true by default.

Having autoDefault == true breaks rendering of the default button when tabbing through it (when it is focused out). At least on Linux Mint 20 with system Qt 5.12.8.

luke-jr commented at 3:38 PM on August 1, 2020:

Weird, sounds like a Qt bug?

hebasto commented at 3:48 PM on August 1, 2020:

Maybe. Didn't track it down though.
luke-jr approved
luke-jr commented at 9:49 PM on July 31, 2020: member

utACK, minor nit
Sjors commented at 1:08 PM on August 28, 2020: member

utACK
MarcoFalke merged this on Aug 28, 2020
MarcoFalke closed this on Aug 28, 2020
sidhujag referenced this in commit 10e88dd23d on Aug 28, 2020
hebasto deleted the branch on Aug 28, 2020
apoelstra referenced this in commit 9ddbb5e744 on Dec 3, 2020
gwillen referenced this in commit 2bb42412e2 on Mar 22, 2021
PastaPastaPasta referenced this in commit b3179a8792 on Jun 27, 2021
PastaPastaPasta referenced this in commit 22c4ede337 on Jun 28, 2021
PastaPastaPasta referenced this in commit d345a797f8 on Jun 29, 2021
PastaPastaPasta referenced this in commit 6bf967c627 on Jul 1, 2021
PastaPastaPasta referenced this in commit fe2992e8ac on Jul 1, 2021
PastaPastaPasta referenced this in commit 7abcce93b6 on Jul 15, 2021
PastaPastaPasta referenced this in commit a560d32f8c on Jul 16, 2021
Fabcien referenced this in commit 483cb49e79 on Sep 17, 2021
bitcoin-core locked this on Feb 15, 2022

Contributors

Linked (view graph)

#24 Give primary action items more visual weight