Peer address column sorting does not honor the inbound/outbound arrow prefix

ghost commented at 7:46 am on August 7, 2021: none

See this peer address column: screenshot

Expected behavior Peer number 196 is sorted below peer number 424, because it is sorted by the first character (arrow) first.

Actual behavior Peer number 196 is sorted below peer number 110. The first (arrow) character seems not to be relevant for sorting?

To reproduce Run with both Onion and I2P network enabled and watch the peer table.

System information 22.0rc2 Debian Buster amd_64

unknown added the label Bug on Aug 7, 2021

unknown renamed this:
~~Peer address column is not sortec correctly~~
Peer address column is not sorted correctly
on Aug 7, 2021

hebasto added the label UX on Aug 7, 2021

hebasto commented at 7:51 am on August 7, 2021: member

@wodry ~~Is this sorting order was restored from the previous Bitcoin Core run, or was set manually in the current session?~~

UPDATE: see #397 (comment)

hebasto commented at 7:55 am on August 7, 2021: member

@wodry ~~Does sorting work for you without https://github.com/bitcoin-core/gui/pull/375/commits/986bf78d7e8fd9b69841ecb0decaff840efe9cff?~~

UPDATE: see #397 (comment)

ghost commented at 7:59 am on August 7, 2021: none

I wanted to sort by peer address (to more easily count I2P and Onion inbound/outbound connections), so I clicked manually on the peer address column header (where the little triangle is), to be sure, sorting by address is active. Then I noticed this issue. Clicking more times on the header reverses sorting order as expected, but issue persists.

hebasto commented at 8:01 am on August 7, 2021: member

For now, only address itself in considered during sorting: https://github.com/bitcoin-core/gui/blob/03826aecc56c5c5c76570805897c2ddf92e11ab6/src/qt/peertablesortproxy.cpp#L27-L28

I wanted to sort by peer address (to more easily count inbound/outbound connections), so I clicked manually on the peer address column header (where the little triangle is), to be sure, sorting by address is active. Then I noticed this issue. Clicking more times on the header reverses sorting order as expected, but issue persists.

Maybe you could be interested in #317 or #363?

unknown renamed this:
~~Peer address column is not sorted correctly~~
Peer address column sorting does not honour the inbound/outbound arrow prefix
on Aug 8, 2021

unknown renamed this:
~~Peer address column sorting does not honour the inbound/outbound arrow prefix~~
Peer address column sorting does not honor the inbound/outbound arrow prefix
on Aug 8, 2021

ghost commented at 4:06 am on August 8, 2021: none

Maybe you could be interested in #317 or #363?

I do not find them reasonable, see my expressions there.

I like the sorting functionality that honors the inbound/outbound arrow prefix. I cannot imagine any use case for not honoring the prefix. Honoring the prefix makes sense, see my use case.

Was the prefix sorting honoring removed? In the past I did not stumble upon this issue, but not sure if I tested it explicitly.

hebasto commented at 10:08 am on August 8, 2021: member

I like the sorting functionality that honors the inbound/outbound arrow prefix. I cannot imagine any use case for not honoring the prefix. Honoring the prefix makes sense, see my use case.

… to more easily count I2P and Onion inbound/outbound connections

Your use case, actually, requires filtering :)

Was the prefix sorting honoring removed?

The implementation remains unchanged since it was introduced in https://github.com/bitcoin/bitcoin/pull/4225.

ghost commented at 6:06 am on August 9, 2021: none

This issue would be obsoleted by alternatives like #401 (B.2) or (B.3)

hebasto commented at 2:02 pm on August 11, 2021: member

Closing, as #317 has been merged.

hebasto closed this on Aug 11, 2021

bitcoin-core locked this on Aug 16, 2022

Peer address column sorting does not honor the inbound/outbound arrow prefix #397