Handle new added plurals in bitcoin_en.ts #406

1. 
   hebasto commented at 9:08 pm on August 21, 2021: member

   This step was missed. See translation_process.md.

   Transifex is smart enough to handle %n in strings as a plural form. Therefore, only two English strings are broken in the GUI on master (and in 22.0).

2. qt: Handle new added plurals in bitcoin_en.ts

   This step was missed. See translation_process.md

   2b3d8f3dde
3. hebasto added the label Needs backport (22.x) on Aug 21, 2021
4. hebasto added the label Translations on Aug 21, 2021
5. hebasto requested review from laanwj on Aug 21, 2021
6. hebasto added this to the milestone 22.0 on Aug 21, 2021
7. 
   shaavan commented at 6:34 am on August 23, 2021: contributor

   Concept ACK

   This PR adds the plural translation for the two strings that use plurals but hitherto didn’t had a plural translation. Adding screenshots to compare the difference between the master and the PR.

   Screenshots (taken from QT Linguistic):

   Master	PR

8. 
   laanwj commented at 4:26 pm on August 23, 2021: member

   I don’t understand, bitcoin_en.ts is auto-generated by make translate, right?
9. 
   hebasto commented at 4:53 pm on August 23, 2021: member

   I don’t understand, bitcoin_en.ts is auto-generated by make translate, right?

   Yes. But make translate does not create plural forms (and, I guess, never did it).

   That’s why we have “Handling Plurals (in source files)” in translation_process.md, no?

10. 
    laanwj commented at 5:14 pm on August 23, 2021: member

    Yes. But make translate does not create plural forms (and, I guess, never did it).

    Ok, so bitcoin_en.ts is updated, not recreated. This is slightly unexpected to me but makes sense.

    ACK 2b3d8f3dde383a53f29b7e7ee53ea364d4ef8938

11. laanwj merged this on Aug 23, 2021
12. laanwj closed this on Aug 23, 2021

    ---

13. sidhujag referenced this in commit 1b952b1b6b on Aug 23, 2021
14. hebasto deleted the branch on Aug 23, 2021
15. hebasto referenced this in commit cb34a0aafe on Aug 23, 2021
16. 
    hebasto commented at 7:45 pm on August 23, 2021: member

    Backported in https://github.com/bitcoin/bitcoin/pull/22629.
17. hebasto removed the label Needs backport (22.x) on Aug 23, 2021
18. laanwj referenced this in commit 4a25e39624 on Aug 26, 2021
19. gwillen referenced this in commit 9fd4e4f44d on Jul 27, 2022
20. gwillen referenced this in commit a94c1d5c61 on Aug 1, 2022
21. bitcoin-core locked this on Aug 23, 2022

Contributors
hebasto shaavan laanwj

Review Requested
laanwj

Labels
Translations

Milestone
22.0