Add missing tooltips to options menu settings #419

1. 
   jarolrod commented at 4:05 pm on September 7, 2021: member

   This adds missing tooltips to the text of the Size of database cache and the Number of script verification threads settings.

   All settings in the Options window will now have appropriate tooltip texts.

2. shaavan approved
3. 
   shaavan commented at 6:13 pm on September 7, 2021: contributor

   tACK b669974a42c6e6e09e6402d8d108a783c63119d9 Tested on Ubuntu 20.04 (Using Qt version 5.12.8)

   The newly added tooltip messages, as well as extracomments, look great. If I imagine myself in the shoes of the translator, I would be able to translate these tooltip messages in my own language effectively. Great Work, @jarolrod!

   Tested Successfully on Ubuntu 20.04. Adding screenshots of the newly added tooltip messages by this PR.

   

4. kristapsk approved
5. 
   kristapsk commented at 7:48 pm on September 7, 2021: contributor

   utACK b669974a42c6e6e09e6402d8d108a783c63119d9
6. in src/qt/forms/optionsdialog.ui:108 in b669974a42 outdated

   103@@ -104,6 +104,9 @@
   104         <layout class="QHBoxLayout" name="horizontalLayout_2_Main">
   105          <item>
   106           <widget class="QLabel" name="databaseCacheLabel">
   107+           <property name="toolTip">
   108+            <string extracomment="Tooltip text for Options window setting that sets the size of the database cache. Explains the corresponding effects of increasing/decreasing this value.">Limit the database cache size to a certain value. A larger cache size can contribute to faster sync times. Lowering the cache size will reduce memory usage.</string>
   

   ---

   ---

   

   hebasto commented at 4:13 pm on September 12, 2021:

   Could this tooltip be aligned with https://github.com/bitcoin-core/gui/blob/ee1db7b6dc4e8a3458a7cfb5ead445c56fb75c51/src/init.cpp#L388 and mention “unused mempool memory”?

   ---

   

   jonatack commented at 6:16 pm on September 12, 2021:

   Maybe something like this.

   0            <string extracomment="Tooltip text for Options window setting that sets the size of the database cache. Explains the corresponding effects of increasing/decreasing this value.">Maximum database cache size. A larger cache size can contribute to faster sync. Lowering the cache size will reduce memory usage. Unused mempool memory is shared for this cache.</string>
   

   A sync can be faster, a sync time can be lower/higher, so maybe s/faster sync time/faster sync/

   (Aside, ISTM the “Unused mempool memory is shared for this cache” text in src/init.cpp is not very clear, or at least not as precise as it could be.)

   ---

   

   jonatack commented at 6:20 pm on September 12, 2021:

   Per doc/reduce-memory.md, this may be worth appending:

   “faster sync, after which the benefit is less pronounced for most use cases–unless fast validation of blocks is important, such as for mining.”

   ---

   

   jarolrod commented at 6:10 am on September 13, 2021:

   Thanks for the excellent review @jonatack, I’ve adopted your suggestions in 9bd168b
7. 
   hebasto commented at 4:15 pm on September 12, 2021: member

   Concept ACK.
8. 
   jonatack commented at 6:18 pm on September 12, 2021: contributor

   Tested ACK b669974a42c6e6e09e6402d8d108a783c63119d9

   modulo suggestion below

9. jarolrod added the label Doc on Sep 12, 2021
10. jarolrod added the label UI on Sep 12, 2021
11. qt: add missing tooltips to options menu settings 9bd168bf54
12. jarolrod force-pushed on Sep 13, 2021
13. 
    jarolrod commented at 6:06 am on September 13, 2021: member

    Updated from b669974 -> 9bd168b (pr419.01 -> pr419.02, diff)

    Changes:

    • Addressed @jonatack suggestions: 1. 2
    • Dropped the word ‘size’ from “A larger cache size …”, as to me this reads better.
14. hebasto approved
15. 
    hebasto commented at 7:19 am on September 13, 2021: member

    ACK 9bd168bf5457c6fd9770769547d8757bf14813b0, tested on Linux Mint 20.2 (Qt 5.12.8).
16. 
    jonatack commented at 1:07 pm on September 13, 2021: contributor

    ACK 9bd168bf5457c6fd9770769547d8757bf14813b0 tested on Debian 5.10.46-4 (2021-08-03)
17. hebasto merged this on Sep 13, 2021
18. hebasto closed this on Sep 13, 2021

    ---

19. sidhujag referenced this in commit 054a140c9d on Sep 13, 2021
20. bitcoin-core locked this on Sep 13, 2022

Contributors
jarolrod shaavan kristapsk hebasto jonatack

Labels
Doc UI