Remove proxy checkboxes from options #421

pull ghost wants to merge 2 commits into bitcoin-core:master from changing 3 files +2 −106
  1. ghost commented at 12:50 AM on September 14, 2021: none

    Never used these checkboxes. No response on IRC or SE so I am assuming its not useful: https://bitcoin.stackexchange.com/questions/109636/understanding-network-options-in-bitcoin-core-gui

    Will get some extra space and need to add checkboxes for onlynet next: https://github.com/bitcoin-core/gui/issues/413

  2. Remove proxy checkboxes from options 5c7ceab136
  3. jarolrod commented at 1:05 AM on September 14, 2021: member

    NACK

    The use cases for these check boxes is specifying where to use a proxy and then setting a different proxy for usage with tor.

    You can't go and start removing code because "you don't use it"; especially when you don't provide any justification and don't fully understand what it's doing.

  4. Remove `updateDefaultProxyNets` from header file 8932e6ada3
  5. ghost commented at 1:12 AM on September 14, 2021: none

    The use cases for these check boxes is specifying where to use a proxy and then setting a different proxy for usage with tor.

    Can you share docs or steps how is this option being used or helpful?

  6. hebasto commented at 8:17 AM on September 14, 2021: member
  7. ghost commented at 10:22 AM on September 14, 2021: none

    @hebasto Thanks for answering. Will close this PR as I am not sure about removal although I think some changes or discussion is required because:

    1. I2P is added which uses 127.0.0.1:7656 as proxy
    2. Few PRs are open in bitcoin/bitcoin which change behaviour of proxy and onlynet. It was discussed that proxy is just a proxy and should remain same for all networks if it can be used.
  8. unknown closed this on Sep 14, 2021

  9. bitcoin-core locked this on Sep 14, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 15:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me