#4092 added the ability to add third-party links to block explorers and the functionality to show a selected translation in that block explorer. As stated in a review in that PR, it is important that we separate these third-party links from all of the other context-menu actions.
“Nit: please add a menu separator between the ’normal’ actions and the ’third party’ actions.”
Since the merge of that PR, there has been a bug where it’s possible that this separator does not get added, and the third-party link actions merge in with our “normal” actions.
Because the addition of the separator is conditional on being at 0, if the first string passed is empty; then the separator will never get added. Now that we’ve iterated past 0, any subsequent actions will get merged in with our normal actions instead of being visually separated into its distinct section.
To Replicate:
- Pass in arguments to the
Options->Display->Third party transaction URLsmenu setting that would result in the first string being empty. Example:| | https://mempool.space/tx/%s | https://blockstream.info/tx/%s. - Restart, navigate to Transaction window and right-click on a transaction.
- Notice that any third-party links you had passed are now actions that have merged in with “normal” actions.
