Do not show unused widgets at startup #439

1. 
   hebasto commented at 7:07 pm on September 29, 2021: member

   On master (8d83f9c1d19d9e701291b9906723dfb548d3dc5f), when starting without wallets the labelWalletEncryptionIcon and labelWalletHDStatusIcon widgets are not used but still visible as empty space:

   

   If one opens any wallet then closes it, the widget layout becomes densed:

   

   This PR makes widget layout densed at startup.

   Fixes #428.

2. qt: Do not show unused widgets at startup

   When starting without wallets the labelWalletEncryptionIcon and
   labelWalletHDStatusIcon widgets are not required.

   489060dcaf
3. hebasto added the label Design on Sep 29, 2021
4. hebasto removed the label Design on Sep 29, 2021
5. hebasto added the label UI on Sep 29, 2021
6. 
   katesalazar commented at 7:25 pm on September 29, 2021: contributor

   Only watched it in action on macOS, but it works. Thank you!
7. 
   jarolrod commented at 1:34 am on September 30, 2021: member

   ACK 489060dcaf45e66c9af4c94cd9376f3f225da18b

   Confirmed the related bug (#428) and tested that this fixes it. The issue here is that we aren’t hiding the unused icons. The PR fixes the issue by hiding them. When they are needed again (when you create a wallet), they are properly shown. Tested on macOS 12.

   Bug on master	PR	Create Wallet, Icons will still Appear

8. 
   promag commented at 8:04 am on September 30, 2021: contributor

   Code review ACK 489060dcaf45e66c9af4c94cd9376f3f225da18b.
9. hebasto merged this on Sep 30, 2021
10. hebasto closed this on Sep 30, 2021

    ---

11. hebasto deleted the branch on Sep 30, 2021
12. sidhujag referenced this in commit 1e56bd5993 on Sep 30, 2021
13. 
    katesalazar commented at 5:25 pm on October 6, 2021: contributor

    Port it back to 22 please? And [maybe 0.21 as well][0]?

    (If backport policy includes this kind of unimportant stuff)

    [0]: #428 (comment)

14. 
    laanwj commented at 4:08 pm on October 14, 2021: member

    @katesalazar Do you have a specific rationale for requesting this PR to be backported? (It doesn’t help that you call it unimportant yourself :smile: )
15. 
    katesalazar commented at 4:35 pm on October 14, 2021: contributor

    @laanwj I could risk suggesting there is no “UI issues” really, but “UI features” and “UI bugs”, then an “UI bug” is relatively unimportant to almost every other kind of bug, still, as a bug, subject to back porting.
16. bitcoin-core locked this on Oct 14, 2022

Contributors
hebasto katesalazar jarolrod promag laanwj

Labels
UI