Network Watch tool #444

1. 
   luke-jr commented at 7:20 pm on October 3, 2021: member

   Now that the crash bug (https://github.com/bitcoinknots/bitcoin/issues/4) has been tracked down, this seems ready for re-opening for Core.

   (Originally https://github.com/bitcoin/bitcoin/pull/9849)

2. hebasto added the label Feature on Oct 3, 2021
3. hebasto renamed this:
   Qt: Network Watch tool
   Network Watch tool
   on Oct 3, 2021
4. 
   jarolrod commented at 7:31 pm on October 3, 2021: member

   Concept ACK

   In general, I’m in favor of not having tons of pop-out windows. May be worth exploring this as a new tab.

   If possible, can you include screenshots of this in action in the OP?

5. 
   luke-jr commented at 7:37 pm on October 3, 2021: member

   Not sure how to add inline images on GitHub, but there’s a sceenshot on the wiki: https://en.bitcoin.it/wiki/File:Bitcoinknots-netwatch.png
6. 
   luke-jr commented at 9:36 pm on October 3, 2021: member

   As for “pop out windows”, I think that’s the correct UX for features like this. Having a tab in the main window just doesn’t seem to fit well.

   Maybe a new debug-window-alike for statistics?

7. 
   jarolrod commented at 4:55 am on October 4, 2021: member

   Have not yet reviewed the code, but:

   Commit 47711fdbc4b5d7f53aa778bcb1af34fc699ab81f must be broken off and opened in the core repo if it is needed. Then this can be based on the PR that would be open. The change to to validationinterface cannot be done in this repo.

   Additionally, the commit history is not clean. The last 4 commits could be squashed onto ae6804e1a1e52611c7f98c6194a8384dda7abe60

8. 
   DrahtBot commented at 11:18 pm on January 24, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept NACK	rebroad
   Concept ACK	jarolrod, jonatack

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #553 (Change address / amount error background by w0xlt)
   • #537 (Point out position of invalid characters in Bech32 addresses by luke-jr)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. DrahtBot added the label Needs rebase on Mar 9, 2022
10. luke-jr force-pushed on May 1, 2022
11. luke-jr force-pushed on May 1, 2022
12. CValidationInterface: ValidationInterfaceUnregistering, called when being unregistered 54a885fb08
13. Qt: Network Watch tool

    Simple realtime log of p2p network activity (blocks and transactions only)
    
    - Doesn't begin logging until opened; limited to 0x400 entries (outputs)
    - Automatically scrolls if left at the bottom of the log; maintains position if left elsewhere
    - Memory-efficient circular buffer; CTransaction references become weak after they're 0x200 entries back in the log
    - Search function that selects all matching log entries, including ongoing

    36c0dfaefc
14. luke-jr force-pushed on May 1, 2022
15. DrahtBot removed the label Needs rebase on May 1, 2022
16. 
    DrahtBot commented at 4:31 pm on August 30, 2022: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

17. DrahtBot added the label Needs rebase on Aug 30, 2022
18. 
    rebroad commented at 7:13 am on September 3, 2022: contributor

    concept NACK - at least, so far, I’m struggling to understand the use case for this. I’d have thought something more command line would make sense, as surely there’d be so much data that it would scroll by too quickly to be useful.
19. 
    jonatack commented at 12:01 pm on September 5, 2022: contributor

    Concept ACK if I’m understanding from the earlier PR. Suggest describing what it does and the use case (what and why) in the pull description.
20. 
    DrahtBot commented at 1:47 am on December 4, 2022: contributor

    There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
21. 
    DrahtBot commented at 2:02 am on March 4, 2023: contributor

    There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
22. 
    DrahtBot commented at 0:18 am on June 2, 2023: contributor

    There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
23. 
    hebasto commented at 12:50 pm on June 4, 2023: member

    Closing this due to lack of activity. Feel free to reopen.
24. hebasto closed this on Jun 4, 2023

    ---

25. bitcoin-core locked this on Jun 3, 2024

Contributors
luke-jr jarolrod DrahtBot rebroad jonatack hebasto

Labels
Needs rebase Feature