Restore “S” accelerator for “Start on system login” option #449

pull luke-jr wants to merge 1 commits into bitcoin-core:master from luke-jr:gui_opt_start_accelerator changing 1 files +2 −2
  1. luke-jr commented at 6:19 pm on October 7, 2021: member

    bitcoin-core/gui#416 changed the option assigned to accelerator key “S”, but there’s no rationale given.

    Best to leave it alone, and give the new option a new accelerator key.

    Since “R” is already taken for Reset, this shifts the new RPC server option to use “P” instead

  2. GUI/Options: Restore "S" accelerator for "Start on system login" option
    Shift RPC server option to use "P" instead
    25a581419d
  3. shaavan commented at 12:42 pm on October 8, 2021: contributor

    No strong opinion for now

    The purpose of the mnemonic shortcut is to increase the speed of workflow. For that, they need to be such that they are easily recognizable and easy to remember. So for the RPC server setting, the most natural shortcut would be the letter R. But since that is already taken, we must use another letter. According to me, the second-best choice is to use the first letter of the second word (i.e., s) instead of the second letter of the first word (i.e., P).

    The reason why I think so is:

    1. The corresponding command line setting for this option is -server, which makes the shortcut s quickly form an association in our mind with this setting, making the shortcut easy to remember.
    2. The second reason being how our brain remembers and correlates things. I am not proficient in its science, but as far as I know, our brain tends to associate a word with its first letter rather than the latter. This is very similar to how we can just quickly recall a complete song in our head if someone tells the few starting words and rhythm of the song, whereas we struggle to recall if someone starts the music from the middle. From this perspective, the shortcut P does not have an as strong association with the word RPC in our mind as the shortcut s has with the word server.

    These were just my two cents. I might be wrong in some of my reasoning. In that case, please correct me. But for now, I think the shortcuts are good as they currently are.

  4. jarolrod commented at 4:39 pm on October 28, 2021: member

    ACK 25a581419d10b3c7d99789da18afd51f2984fbc8

    I think this is fine to do. cc @Sjors any opinion on this change?

  5. Sjors commented at 11:01 am on October 29, 2021: member

    Using R as a shortcut for RPC clashed according to @hebasto: #416 (review)

    Using P instead is fine by me.

  6. hebasto renamed this:
    GUI/Options: Restore "S" accelerator for "Start on system login" option
    Restore "S" accelerator for "Start on system login" option
    on Nov 21, 2021
  7. hebasto added the label UX on Nov 21, 2021
  8. hebasto approved
  9. hebasto commented at 9:21 pm on November 21, 2021: member
    ACK 25a581419d10b3c7d99789da18afd51f2984fbc8, tested on Linux Mint 20.2 (Qt 5.12.8).
  10. hebasto merged this on Nov 21, 2021
  11. hebasto closed this on Nov 21, 2021

  12. sidhujag referenced this in commit e426c46d81 on Nov 22, 2021
  13. sidhujag referenced this in commit d0ab4147e4 on Nov 23, 2021
  14. bitcoin-core locked this on Nov 21, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-23 00:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me