src/net.cpp: Fail to listen alert text break fix #476

pull RandyMcMillan wants to merge 1 commits into bitcoin-core:master from bitcoincore-dev:net-cpp-listen-alert changing 1 files +1 −1

RandyMcMillan commented at 3:12 AM on November 20, 2021: contributor

No description provided.
src/net.cpp: Fail to listen alert text break fix a5097f37ff
RandyMcMillan commented at 3:14 AM on November 20, 2021: contributor

When another instance of bitcoin is running:

Before:

After:
shaavan approved
shaavan commented at 7:16 AM on November 20, 2021: contributor

ACK a5097f37ffead4790c11da66a8156b828f812ec5

Simple but necessary change. Before line break, the usage of -listen=0 was not evident, and - could have confused a simple text hyphen. This PR removes the scope for that doubt. Nice catch, @RandyMcMillan!
katesalazar commented at 11:49 AM on November 21, 2021: contributor

Concept ACK.
hebasto commented at 8:34 PM on November 21, 2021: member

Why don't use https://github.com/bitcoin-core/gui/blob/19815b096c6a2b2e0bcb802e9e5842e67952993e/src/qt/rpcconsole.cpp#L497 which we already use in our code?

For translated messages we cannot be sure that the chosen location of the hardcoded \n is optimal.
hebasto commented at 8:39 PM on November 21, 2021: member

@RandyMcMillan

Could you move this PR into the main repo because it changes the code outside the src/qt/ directory?
RandyMcMillan closed this on Nov 22, 2021
bitcoin-core locked this on Nov 22, 2022

Contributors