rpcconsole:accessibility - new shortcuts enable single hand gesture

RandyMcMillan commented at 2:14 pm on November 22, 2021: contributor

qt:rpcconsole:accessibility - new shortcuts enable single hand gesture beef7941c7

RandyMcMillan commented at 2:15 pm on November 22, 2021: contributor

Accessibility improvement:

CTRL + 1 CTRL + 2 CTRL + 3 CTRL + 4

are easily accessed by a single left hand motion and greatly simplifies a 2 handed gesture.

Screen Shot 2021-11-22 at 9 27 34 AM

katesalazar commented at 9:09 am on November 23, 2021: contributor

If you look at this menu from GNU/Linux:

And hit the “alt” key, then W (for Window), M (for Minimize), S (for Sending addresses), R (for Receiving addresses), I (for Information), C (for Console), N (for Network Traffic), and P (for Peers) get conveniently highlighted. Have you considered that?

I checked in my mac build the “alt” key doesn’t do such thing.

RandyMcMillan commented at 1:20 pm on November 23, 2021: contributor

I agree - more short cuts can be added - and thought about from an ergonomic perspective - Just as modal editors like Vim minimize motion and optimize for speed and “muscle memory”.

katesalazar commented at 1:29 pm on November 23, 2021: contributor

IMO “Receiving addresses” is much more important than “Network Traffic”, for one.

If you are going to stand for this, I’d suggest propose the change only for macs and add numeric shortcuts to the other controls.

RandyMcMillan commented at 1:35 pm on November 23, 2021: contributor

From an accessibility perspective - it is ideal to keep shortcuts to 2 key combinations

CTRL + <key> ALT + <key>

3 key combos:

SHIFT + CTRL + <key>

are less friendly to impaired users - especially when considering motor impairment or loss of digits (fingers).

RandyMcMillan commented at 1:51 pm on November 23, 2021: contributor

The “tab through” functionality can also be optimized…

These types of changes usually generate a lot of “diff junk” in the QT .ui files and is frowned upon - but i believe this is an important topic that warrants a continued discussion, research and scrutiny. :)

katesalazar commented at 2:00 pm on November 23, 2021: contributor

I ran this on KDE, maybe it felt a bit weird, but not enough to NAK.

RandyMcMillan commented at 2:24 pm on November 23, 2021: contributor

If you think about it from a single left handed perspective (loss of limb) - it ought to make sense…

Then single right handed (using same keys as left handed)…

Then approach it from a two handed perspective…

RandyMcMillan commented at 2:39 pm on November 23, 2021: contributor

More generally - try to use the gui - with only one hand - you will quickly see how badly the GUI falls short…

jarolrod commented at 1:59 am on November 24, 2021: member

In terms of real world usability, considering all types of different keyboards that can be used as input, CTRL+ALPHA is better.

For example, I do not have a number row on my keyboard. I can access numeric keys, but they are hidden on a different layer after pressing a modifier key. In terms of usability, this would be a downgrade for me.

If there is a good argument that this is better for some users who are disabled, then this feature could be delegated behind a setting that can toggle between mnemonic shortcuts and accessibility oriented shortcuts.

RandyMcMillan commented at 12:19 pm on November 24, 2021: contributor

I greatly appreciate your time and feedback…

While thinking more about this - I noticed that…

ALT + 1 ALT + 2 ALT + 3 ALT + 4

Doesn’t raise the wallet interface and set focus - as it clearly should…

And there is no indication of this functionality in the MacOS interface?

katesalazar commented at 7:37 pm on November 24, 2021: contributor

Seen yesterday those combinations circle through the 4 wallet tabs in at least one desktop environment interface. If it doesnt do for every, I guess it could be bug, if so, separate from this PR.

On Wed, Nov 24, 2021 at 1:20 PM @RandyMcMillan @.***> wrote:

I greatly appreciate your time and feedback…

While thinking more about this - I noticed that…

ALT + 1 ALT + 2 ALT + 3 ALT + 4

Doesn’t raise the wallet interface and set focus - as it clearly should…

And there is no indication of this functionality in the MacOS interface?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/pull/481#issuecomment-977824764, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W762J6CK3ZGH4ZAVZDUNTJ7RANCNFSM5IRDPPGA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

katesalazar commented at 7:47 pm on November 24, 2021: contributor

I was reserving about concept ACKing too early because I was seeing something like this probably coming…

… related to that, so I was thinking about configurable key shortcuts, and was already imaging this usual needlessly stupid GUI dev hell; like the case for detecting caps lock before an alpha key is pressed, when entering a password; to be expected here. :pray:🙏

So good luck if you have a look at any of that! :laughing:😂

On Wed, Nov 24, 2021 at 2:59 AM Jarol Rodriguez @.***> wrote:

@.**** commented on this pull request.

In terms of real world usability, considering all types of different keyboards that can be used as input, CTRL+ALPHA is better.

For example, I do not have a number row on my keyboard. I can access numeric keys, but they are hidden on a different layer after pressing a modifier key. In terms of usability, this would be a downgrade for me.

If there is a good argument that this is better for some users who are disabled, then this feature could be delegated behind a setting that can toggle between mnemonic shortcuts and accessibility oriented shortcuts.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/pull/481#pullrequestreview-814353528, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W4RWVHXEVC2KZHYZSDUNRBJNANCNFSM5IRDPPGA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

RandyMcMillan marked this as a draft on Nov 25, 2021

hebasto added the label UX on Nov 25, 2021

luke-jr changes_requested

luke-jr commented at 11:47 pm on November 30, 2021: member

Concept NACK. Standard shortcuts like this are Ctrl+Letter (like we have right now).

Furthermore, there’s no particular reason for this order of debug window tabs, and they could very well be reordered (eg, by inserting one in the middle) in the future.

shaavan commented at 1:07 pm on December 1, 2021: contributor

Concept NACK

I was concept 0 on this PR, to begin with. Because:

Many bitcoin-core GUI users would be pretty comfortable with current letter shortcuts and have a kind of muscle memory for them. Changing those would create unnecessary strain in their workflow.
To press ctrl + number with one hand, you have to bend your hand in kind of an awkward and out-of-place way, especially on an external full-size keyboard. Alt + number would improve over the current ctrl + number implementation. But it seems like Alt + number doesn’t seem to work (as discussed here).

But after reading @luke-jr’s thoughts:

Furthermore, there’s no particular reason for this order of debug window tabs, and they could very well be reordered (e.g., by inserting one in the middle) in the future.

I agree with him. I think the above statement is a strong argument against this PR. In my view, the improved accessibility doesn’t balance the unnecessary maintenance burden this PR introduces. That’s why I am concept NACK on this PR.

hebasto renamed this:
~~qt:rpcconsole:accessibility - new shortcuts enable single hand gesture~~
rpcconsole:accessibility - new shortcuts enable single hand gesture
on Dec 14, 2021

RandyMcMillan closed this on Dec 14, 2021

bitcoin-core locked this on Dec 14, 2022

rpcconsole:accessibility - new shortcuts enable single hand gesture #481