Add a close (X) button to the Peers Detail panel. Reuse the same icon used in the Console Tab. The close button deselects the peer highlighted in the PeerTableView and hides the detail panel.
fixes #485
Co-authored-by: [@w0xlt](/bitcoin-core-gui/contributor/w0xlt/) <w0xlt@users.noreply.github.com>
Tooltip message for better UX.
554@@ -555,6 +555,7 @@ RPCConsole::RPCConsole(interfaces::Node& node, const PlatformStyle *_platformSty
555 ui->lineEdit->setMaxLength(16 * 1024 * 1024);
556 ui->messagesWidget->installEventFilter(this);
557
558+ connect(ui->hidePeersDetailButton, &QAbstractButton::clicked, [this] { hidePeersDetail(); });
Just
0connect(ui->hidePeersDetailButton, &QAbstractButton::clicked, this, &RPCConsole::clearSelectedNode);
and ditch hidePeersDetails.
We reuse the same icon used in the Console Tab for Gui consistency.
How so? One clears the console while the other unselects the peer.
Is there a better icon to use for a “close” action?
We don’t have a “clear” icon in the repo - but something like this would be more appropriate for “clear console”. So reusing the (X) icon seems prudent.
1022- </property>
1023- <property name="textInteractionFlags">
1024- <set>Qt::LinksAccessibleByMouse|Qt::TextSelectableByKeyboard|Qt::TextSelectableByMouse</set>
1025- </property>
1026- </widget>
1027+ <item>
1100+ <width>32</width>
1101+ <height>32</height>
1102+ </size>
1103+ </property>
1104+ <property name="toolTip">
1105+ <string>Hide Peers Detail</string>
extracomment property. I have written some notes on constructing translator comments here: translator-comments.md
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | pablomartin4btc, hebasto |
| Concept ACK | jarolrod |
| Stale ACK | rsafier, w0xlt, hernanmarino |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
No conflicts as of last run.
You can delete the last commit (git reset --hard 718589f) and apply the patch below.
0diff --git a/src/qt/forms/debugwindow.ui b/src/qt/forms/debugwindow.ui
1index 15e0d3fad..ad671b02e 100644
2--- a/src/qt/forms/debugwindow.ui
3+++ b/src/qt/forms/debugwindow.ui
4@@ -984,6 +984,117 @@
5 </size>
6 </property>
7 <layout class="QVBoxLayout" name="verticalLayout_8">
8+ <item>
9+ <layout class="QHBoxLayout" name="horizontalLayout_8">
10+ <property name="topMargin">
11+ <number>0</number>
12+ </property>
13+ <property name="bottomMargin">
14+ <number>0</number>
15+ </property>
16+ <item>
17+ <widget class="QLabel" name="peerHeading">
18+ <property name="sizePolicy">
19+ <sizepolicy hsizetype="Preferred" vsizetype="Minimum">
20+ <horstretch>0</horstretch>
21+ <verstretch>0</verstretch>
22+ </sizepolicy>
23+ </property>
24+ <property name="minimumSize">
25+ <size>
26+ <width>0</width>
27+ <height>32</height>
28+ </size>
29+ </property>
30+ <property name="font">
31+ <font>
32+ <pointsize>10</pointsize>
33+ </font>
34+ </property>
35+ <property name="cursor">
36+ <cursorShape>IBeamCursor</cursorShape>
37+ </property>
38+ <property name="text">
39+ <string>Select a peer to view detailed information.</string>
40+ </property>
41+ <property name="alignment">
42+ <set>Qt::AlignHCenter|Qt::AlignTop</set>
43+ </property>
44+ <property name="wordWrap">
45+ <bool>true</bool>
46+ </property>
47+ <property name="textInteractionFlags">
48+ <set>Qt::LinksAccessibleByMouse|Qt::TextSelectableByKeyboard|Qt::TextSelectableByMouse</set>
49+ </property>
50+ </widget>
51+ </item>
52+ <item>
53+ <widget class="QWidget" name="hidePeersDetail" native="true">
54+ <property name="enabled">
55+ <bool>true</bool>
56+ </property>
57+ <property name="minimumSize">
58+ <size>
59+ <width>32</width>
60+ <height>32</height>
61+ </size>
62+ </property>
63+ <property name="maximumSize">
64+ <size>
65+ <width>32</width>
66+ <height>32</height>
67+ </size>
68+ </property>
69+ <widget class="QToolButton" name="hidePeersDetailButton">
70+ <property name="geometry">
71+ <rect>
72+ <x>0</x>
73+ <y>0</y>
74+ <width>32</width>
75+ <height>32</height>
76+ </rect>
77+ </property>
78+ <property name="minimumSize">
79+ <size>
80+ <width>32</width>
81+ <height>32</height>
82+ </size>
83+ </property>
84+ <property name="baseSize">
85+ <size>
86+ <width>32</width>
87+ <height>32</height>
88+ </size>
89+ </property>
90+ <property name="toolTip">
91+ <string>Hide Peers Detail</string>
92+ </property>
93+ <property name="layoutDirection">
94+ <enum>Qt::LeftToRight</enum>
95+ </property>
96+ <property name="text">
97+ <string />
98+ </property>
99+ <property name="icon">
100+ <iconset resource="../bitcoin.qrc">
101+ <normaloff>:/icons/remove</normaloff>
102+ :/icons/remove
103+ </iconset>
104+ </property>
105+ <property name="iconSize">
106+ <size>
107+ <width>22</width>
108+ <height>22</height>
109+ </size>
110+ </property>
111+ <property name="shortcut">
112+ <string>Ctrl+X</string>
113+ </property>
114+ </widget>
115+ </widget>
116+ </item>
117+ </layout>
118+ </item>
119 <item>
120 <widget class="QLabel" name="peerHeading">
121 <property name="sizePolicy">
Commit: 2ae79d0954c46862535114c0d3f7bcfe2837918f
To avoid re-adding diff junk to the debugwindow.ui file - I prefer to add translator comments in a follow up PR.
991+ </property>
992+ <property name="bottomMargin">
993+ <number>0</number>
994+ </property>
995+ <item>
996+ <widget class="QLabel" name="peerHeading">
tACK d59363aaa0f39da8f27fead0b8e5b0c1a5a32226
nit: I’d update both the title of the PR and the commit subject line for something more meaningful or concise, it would provide clarity of the changes being made. In the specific case of the commit subject line it’s recommended to keep its length 50 chars max according to the guidelines. Perhaps something like gui: Add close Peers detail panel feature could work.
If you mention “fix” follow by the issue # it will link them both together.
@pablomartin4btc - great suggestion - thanks!
You are welcome, the “gui:” prefix, IMO, would be more for the commit subject line, since we are already on the gui repo, we would’t need to clarify it in the PR title.
@pablomartin4btc - I am just grateful for the interest - I had forgotten about this PR :)
retesting on MacOS X86_64 Arm64 right now.
🤔 There hasn’t been much activity lately and the CI seems to be failing.
If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn’t been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.
436ac4f duplicate ui element removed per @pablomartin4btc comment.
tACK 436ac4f42b88e8131bf1e02554a20b3c549e7d6f
nit: not a blocker, please consider previous feedback regarding commit title length and meaningfulness, maybe gui: + this PR’s title.
🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the documentation.
Possibly this is due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
Leave a comment here, if you need help tracking down a confusing failure.
Add a close (X) button to the Peers Detail panel.
Reuse the same icon used in the Console Tab.
The close button deselects the peer highlighted
in the PeerTableView and hides the detail panel.
This PR addresses issue #485:
Co-authored-by: @w0xlt <w0xlt@users.noreply.github.com>