Change 'Show' icon #516

pull w0xlt wants to merge 1 commits into bitcoin-core:master from w0xlt:change_details_icon changing 2 files +2 −2

w0xlt commented at 5:21 PM on December 31, 2021: contributor

This PR changes the 'Show' icon in receivecoinsdialog.{ui,cpp}.

The current icon for the 'Show' button is the edit icon, which makes it look like records can be edited on this screen (which is not the case).

The icon already available that seems to be the most suitable for this case is the "eye", so this PR makes this change.

PR	Master
<img width="209" alt="PR" src="https://user-images.githubusercontent.com/94266259/147833993-0758291c-af87-49a8-ae20-7fb9f944cb38.png">	<img width="209" alt="master" src="https://user-images.githubusercontent.com/94266259/147833992-30d7549d-be7b-4479-8bca-314810e3adb8.png">

Change 'Show' icon 1831d43e8f
kristapsk approved
kristapsk commented at 6:00 PM on December 31, 2021: contributor

utACK 1831d43e8fb73358858907e1d95ce54e1f42b2e7
shaavan approved
shaavan commented at 6:35 AM on January 4, 2022: contributor
ACK 1831d43e8fb73358858907e1d95ce54e1f42b2e7
- The eye icon makes more sense than a pen icon for the "show" option.
- Tested successfully on Ubuntu 20.04 (Using Qt version 5.12.8).
Screenshot:

Master PR
hebasto approved
hebasto commented at 10:47 AM on January 4, 2022: member

ACK 1831d43e8fb73358858907e1d95ce54e1f42b2e7
hebasto merged this on Jan 4, 2022
hebasto closed this on Jan 4, 2022
sidhujag referenced this in commit cf548c3617 on Jan 4, 2022
w0xlt deleted the branch on Jan 21, 2022
bitcoin-core locked this on Jan 21, 2023

Contributors