Add address relay/processed/rate-limited fields to peer details

jonatack commented at 11:10 pm on January 20, 2022: contributor

This pull adds the following address fields in rpc getpeerinfo and cli -netinfo to the gui peers details:

Address Relay (Yes/No)
Addresses Processed (integer)
Addresses Rate-Limited (integer)

and uses the additional horizontal space to display “Last Transaction” (instead of “Last Tx”).

Screenshot from 2022-01-21 00-05-49

DrahtBot commented at 7:29 am on January 21, 2022: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#505 (RPCConsole: add hidePeersDetail() button and functionality by RandyMcMillan)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

w0xlt approved

w0xlt commented at 9:32 am on January 23, 2022: contributor

tACK 5efd391 on Ubuntu 21.10 (Qt 5.15.2).

hebasto added the label Feature on Jan 24, 2022

hebasto commented at 8:21 am on January 24, 2022: member

Concept ACK, the added fields correspond to the getpeerinfo RPC output.

gui: add "Address Relay" (m_addr_relay_enabled) to peer details a465a66ef2

gui: add "Addresses Processed" (m_addr_processed) to peer details 19623d3182

gui: add "Addresses Rate-Limited" (m_addr_rate_limited) to peer details 6cd132d380

gui: use available space to display "Last Transaction" in peer details 9fbd1bb7fa

in src/qt/forms/debugwindow.ui:1597 in a00bc71773 outdated

1591@@ -1592,6 +1592,84 @@
1592                 </widget>
1593                </item>
1594                <item row="23" column="0">
1595+                <widget class="QLabel" name="peerAddrRelayEnabledLabel">
1596+                 <property name="toolTip">
1597+                  <string>Whether we relay addresses to this peer.</string>

hebasto commented at 8:32 am on January 24, 2022:

Could you add an extracomment attribute as a translator comment for newly added tooltip strings?

As an example see dbde0558ce73db4c901dbaa2eddc634701fa1d0d.

jonatack commented at 9:58 am on January 24, 2022:

Thanks – done.

jonatack force-pushed on Jan 24, 2022

jonatack commented at 10:01 am on January 24, 2022: contributor

Thanks @w0xlt and @hebasto, updated.

 0diff --git a/src/qt/forms/debugwindow.ui b/src/qt/forms/debugwindow.ui
 1index 174954087..219680102 100644
 2--- a/src/qt/forms/debugwindow.ui
 3+++ b/src/qt/forms/debugwindow.ui
 4@@ -1355,7 +1355,7 @@
 5                <item row="13" column="0">
 6                 <widget class="QLabel" name="peerLastTxLabel">
 7                  <property name="toolTip">
 8-                  <string>Elapsed time since a novel transaction accepted into our mempool was received from this peer.</string>
 9+                  <string extracomment="Tooltip text for the Last Transaction field in the peer details area.">Elapsed time since a novel transaction accepted into our mempool was received from this peer.</string>
10                  </property>
11                  <property name="text">
12                   <string>Last Transaction</string>
13@@ -1594,7 +1594,7 @@
14                <item row="23" column="0">
15                 <widget class="QLabel" name="peerAddrRelayEnabledLabel">
16                  <property name="toolTip">
17-                  <string>Whether we relay addresses to this peer.</string>
18+                  <string extracomment="Tooltip text for the Address Relay field in the peer details area.">Whether we relay addresses to this peer.</string>
19                  </property>
20                  <property name="text">
21                   <string>Address Relay</string>
22@@ -1620,7 +1620,7 @@
23                <item row="24" column="0">
24                 <widget class="QLabel" name="peerAddrProcessedLabel">
25                  <property name="toolTip">
26-                  <string>Total number of addresses processed, excluding those dropped due to rate limiting.</string>
27+                  <string extracomment="Tooltip text for the Addresses Processed field in the peer details area.">Total number of addresses processed, excluding those dropped due to rate-limiting.</string>
28                  </property>
29                  <property name="text">
30                   <string>Addresses Processed</string>
31@@ -1646,7 +1646,7 @@
32                <item row="25" column="0">
33                 <widget class="QLabel" name="peerAddrRateLimitedLabel">
34                  <property name="toolTip">
35-                  <string>Total number of addresses dropped due to rate limiting.</string>
36+                  <string extracomment="Tooltip text for the Addresses Rate-Limited field in the peer details area.">Total number of addresses dropped due to rate-limiting.</string>
37                  </property>
38                  <property name="text">
39                   <string>Addresses Rate-Limited</string>

hebasto approved

hebasto commented at 10:29 am on January 24, 2022: member

ACK 9fbd1bb7fabec76c668a649967f6f4e355e6ca59, tested on Ubuntu 21.10 (Qt 5.15.2).

hebasto added this to the milestone 23.0 on Jan 26, 2022

w0xlt approved

w0xlt commented at 7:51 pm on January 28, 2022: contributor

reACK 9fbd1bb

hebasto merged this on Jan 28, 2022

hebasto closed this on Jan 28, 2022

sidhujag referenced this in commit 8bdd318a1e on Jan 29, 2022

in src/qt/forms/debugwindow.ui:1626 in 9fbd1bb7fa

1621+                <widget class="QLabel" name="peerAddrProcessedLabel">
1622+                 <property name="toolTip">
1623+                  <string extracomment="Tooltip text for the Addresses Processed field in the peer details area.">Total number of addresses processed, excluding those dropped due to rate-limiting.</string>
1624+                 </property>
1625+                 <property name="text">
1626+                  <string>Addresses Processed</string>

hebasto commented at 8:19 am on February 17, 2022:

A feedback from a Transifex translator:

Rather: “Processed Addresses”

jonatack commented at 9:10 am on February 17, 2022:

If “processed” was an adjective, then I would agree with the feedback, i.e. “red car” and not “car red”.

However, in this case it is a verb and this is fine as-is, i.e. “cars sold” vs “sold cars”.

AO-LocLab commented at 4:27 pm on February 17, 2022:

Hi @jonatack The lack of string context in Transifex is a real problem for this project, as proper context (dev notes and/or screenshots) are essential to achieve quality translations. How is this string used, is this a title, a tooltip, a notification? Do we actually mean “Addresses are processed”?

jonatack commented at 4:59 pm on February 20, 2022:

@AO-LocLab it is the field name in the peer details area, as displayed in the screenshot in the PR description. There is also a tooltip saying this, and its explanatory description, 3 lines higher at line 1623. There is one of these for each added field. I don’t know if they are visible in transifex.

0<string extracomment="Tooltip text for the Addresses Processed field in the peer details area.">
1    Total number of addresses processed, excluding those dropped due to rate-limiting.</string>

hebasto commented at 5:09 pm on February 20, 2022:

I don’t know if they are visible in transifex.

Screenshot from 2022-02-20 19-09-24

hebasto commented at 5:12 pm on February 20, 2022:

Although, this one has no developer notes:

Screenshot from 2022-02-20 19-12-06

jonatack commented at 5:16 pm on February 20, 2022:

Although, this one has no developer notes:

Should an extracomment be added, or something else?

hebasto commented at 5:20 pm on February 20, 2022:

Although, this one has no developer notes:

Should an extracomment be added, or something else?

Actually, extracomments in *.ui files are Qt translator comments which are presented on Transifex as “developer notes”.

hebasto commented at 5:21 pm on February 20, 2022:

Should an extracomment be added…?

That is the plan :)

jonatack commented at 5:36 pm on February 20, 2022:

Ok! Will propose adding extracomments to the titles, then (if I understand correctly) and maybe to the tooltips without them.

hebasto commented at 5:54 pm on February 20, 2022:

Ok! Will propose adding extracomments to the titles, then (if I understand correctly) and maybe to the tooltips without them.

Thank you!

jonatack commented at 10:37 pm on February 20, 2022:

Started adding and improving the dev notes (and tooltips) in #554.

in src/qt/forms/debugwindow.ui:1652 in 9fbd1bb7fa

1647+                <widget class="QLabel" name="peerAddrRateLimitedLabel">
1648+                 <property name="toolTip">
1649+                  <string extracomment="Tooltip text for the Addresses Rate-Limited field in the peer details area.">Total number of addresses dropped due to rate-limiting.</string>
1650+                 </property>
1651+                 <property name="text">
1652+                  <string>Addresses Rate-Limited</string>

hebasto commented at 8:20 am on February 17, 2022:

A feedback from a Transifex translator:

Rather: “Rate-Limited Addresses”

jonatack commented at 9:11 am on February 17, 2022:

Same response as #526 (review).

hebasto commented at 8:21 am on February 17, 2022: member

Cross-posted feedback from French translation team.

jonatack deleted the branch on Feb 17, 2022

hebasto referenced this in commit ae005a647f on Mar 20, 2022

sidhujag referenced this in commit 5714b7a26f on Mar 22, 2022

bitcoin-core locked this on Feb 20, 2023

Add address relay/processed/rate-limited fields to peer details #526

Conflicts