network graph - show/hide panels based on window width/height #540
pull RandyMcMillan wants to merge 5 commits into bitcoin-core:master from RandyMcMillan:1643654791-show-hide-gui-elements-based-on-size changing 5 files +224 −192-
RandyMcMillan commented at 7:08 pm on January 31, 2022: contributorThe debugwindow - network graph hides ui elements btnClearTrafficGraph, lblGraphRange, sldGraphRange when at minimumHeight, it also hides the groupBox at minimumWidth - this maximizes the dimensions of the traffic graph in these small dimensions.
-
RandyMcMillan commented at 7:15 pm on January 31, 2022: contributor
-
RandyMcMillan force-pushed on Feb 2, 2022
-
RandyMcMillan force-pushed on Feb 2, 2022
-
RandyMcMillan commented at 9:16 am on February 2, 2022: contributorcommit a1bd27fa5f2c166798e331081403040027656889 rebase and set side panel to hide at 2x the minimum width of app window. Same functionality as #539 commit 874b2d8 screen cast - without other changes.
-
jarolrod added the label Feature on Feb 2, 2022
-
jarolrod added the label UI on Feb 2, 2022
-
RandyMcMillan commented at 3:50 pm on February 4, 2022: contributor
Part of what I have added to my thought process is how this will translate to the mobile U/I (android/etc) - I have implemented a hybrid version of both of these approaches - but haven’t posted a PR to it.
Some of my conclusions to these approaches (and the gui repo in general) - is that it may be beneficial to have a hybrid of both implementations - it would lend itself to a mobile portrait/landscape design idiom.
I may be wrong - but there doesn’t seem to be enough reviewing members/contributors that have experience in the nuances of cross platform design including mobile U/I support. I don’t see the Android developers reviewing this stuff to ensure up/down stream compatibility - that seems weird/negligent to me, having done mobile UI design for web, macOS/(OSX) and iOS and (Apache/Cordova) work.
-
RandyMcMillan commented at 7:13 pm on February 5, 2022: contributor
I find it strange that this web interface collapses in a “responsive U/I” design - but you ask why would “we” want to do this. Who is “we”? Because most of modern UI/UX interface design has adopted this a long time ago at this point.
-
luke-jr commented at 10:34 pm on February 5, 2022: memberHow about moving the current values on top of the graph (top-left?) instead?
-
RandyMcMillan commented at 7:31 pm on February 8, 2022: contributor@luke-jr - I agree - thanks for your suggestion - I will revisit this PR shortly
-
hebasto renamed this:
gui: network graph - show/hide panels based on window width/height
network graph - show/hide panels based on window width/height
on Feb 9, 2022 -
RandyMcMillan force-pushed on Feb 14, 2022
-
RandyMcMillan commented at 6:28 pm on February 14, 2022: contributor
@luke-jr - how about a simple overlay? Note: the transparency can (obviously) be adjusted.
note: this approach removed 39 lines of code.
-
luke-jr commented at 7:24 pm on February 14, 2022: memberThat looks kind of hard to read IMO. Maybe just make it the default widget background behind the text? (QFrame for borders?)
-
RandyMcMillan force-pushed on Feb 14, 2022
-
RandyMcMillan commented at 10:17 pm on February 14, 2022: contributor
@luke-jr - This is pretty close to the original colors… I will tighten all this up - I just want to make sure the colors are good before anything else…
-
luke-jr commented at 11:15 pm on February 14, 2022: member
The correct colours to match “original” are going to vary based on the user’s colour theme.
But maybe as long as we make sure the text and background have good contrast, the theme doesn’t need to apply within the overlay since the graph itself is unthemed.
I do think the current screenshots are still a bit hard to read. Maybe bolding the text will do the trick?
-
RandyMcMillan commented at 11:31 am on February 15, 2022: contributorI will look into toggling the graph (light/dark) themes based on system preferences - it may be a good “feature”.
-
gui: network graph - show/hide panels based on window width/height
The debugwindow - network graph hides ui elements btnClearTrafficGraph, lblGraphRange, sldGraphRange when at minimumHeight, it also hides the groupBox at minimumWidth - this maximizes the dimensions of the traffic graph in these small dimensions.
-
gui: network graph - show/hide panels based on click event cf6f2324f0
-
gui: network graph - show/hide slider based on click event dbb007e00e
-
gui: network graph - totals frame - implement original color scheme 6577b7bae9
-
RandyMcMillan force-pushed on Feb 15, 2022
-
RandyMcMillan commented at 11:58 pm on February 15, 2022: contributor
I have adjusted the colors based on the global template and an accessibility audit. If we are going to be this nuanced - please actually compile/run the PR changes. [deleted]
-
RandyMcMillan commented at 11:58 pm on February 15, 2022: contributor
-
RandyMcMillan force-pushed on Feb 16, 2022
-
gui: network graph - totals frame - background color base on acc. audit 1afde286fc
-
RandyMcMillan force-pushed on Feb 16, 2022
-
RandyMcMillan marked this as a draft on Feb 17, 2022
-
DrahtBot commented at 5:41 am on February 25, 2022: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
Conflicts
No conflicts as of last run.
-
hebasto commented at 3:18 pm on March 27, 2023: memberClosing this due to lack of activity. Feel free to reopen.
-
hebasto closed this on Mar 27, 2023
-
bitcoin-core locked this on Mar 26, 2024
This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-22 01:20 UTC
More mirrored repositories can be found on mirror.b10c.me