External signer Send button disabled #551

issue Sjors openend this issue on February 18, 2022

Sjors commented at 5:22 pm on February 18, 2022: member

When using an external signer, the Create Unsigned button actually signs on the hardware device and the Send button is incorrectly disabled. Probably a regression from #441.

cc @achow101
Sjors added the label Bug on Feb 18, 2022
Sjors added this to the milestone 23.0 on Feb 18, 2022
Sjors commented at 5:23 pm on February 18, 2022: member

(I took the liberty of assigning it 23.0 since it’s a regression, cc @hebasto)
hebasto commented at 6:33 pm on February 20, 2022: member

For me pressing the “Create Unsigned” works as signing and send.

What correct behavior is expected?

Also maybe a button text could be adjusted for the external signer case?
Sjors commented at 9:18 pm on February 20, 2022: member

For me pressing the “Create Unsigned” works as signing and send.

That’s both incorrect and confusing. It means the user can’t make a PSBT if they want to, and they might think the wallet is broken because “Send” is disabled.

I think for external signers both buttons should be enabled, and the Create Unsigned should create a PSBT for the clipboard, not sign on the device.
kristapsk commented at 10:05 pm on February 20, 2022: contributor

Agree with @Sjors.
Sjors referenced this in commit a49bb0c832 on Feb 21, 2022
Sjors referenced this in commit 33d165d802 on Feb 24, 2022
Sjors referenced this in commit 4ed2a3bd0c on Mar 10, 2022
Sjors referenced this in commit 86e3e2cda8 on Mar 10, 2022
Sjors referenced this in commit 225794f42f on Mar 15, 2022
Sjors referenced this in commit 347871fd43 on Mar 15, 2022
Sjors referenced this in commit 0538614804 on Mar 15, 2022
Sjors referenced this in commit 2efdfb88aa on Mar 16, 2022
hebasto closed this on Mar 17, 2022
hebasto referenced this in commit aece566249 on Mar 17, 2022
bitcoin-core locked this on Mar 17, 2023

Contributors
Sjors hebasto kristapsk

Labels
Bug

Milestone
23.0