External signer Send button disabled #551

1. 
   Sjors commented at 5:22 PM on February 18, 2022: member

   When using an external signer, the Create Unsigned button actually signs on the hardware device and the Send button is incorrectly disabled. Probably a regression from #441.

   <img width="486" alt="Schermafbeelding 2022-02-18 om 17 27 00" src="https://user-images.githubusercontent.com/10217/154731834-b3371eda-1988-4c2b-b7f0-75440e6c1fe1.png">

   cc @achow101

2. Sjors added the label Bug on Feb 18, 2022
3. Sjors added this to the milestone 23.0 on Feb 18, 2022
4. 
   Sjors commented at 5:23 PM on February 18, 2022: member

   (I took the liberty of assigning it 23.0 since it's a regression, cc @hebasto)

5. 
   hebasto commented at 6:33 PM on February 20, 2022: member

   For me pressing the "Create Unsigned" works as signing and send.

   What correct behavior is expected?

   Also maybe a button text could be adjusted for the external signer case?

6. 
   Sjors commented at 9:18 PM on February 20, 2022: member

   For me pressing the "Create Unsigned" works as signing and send.

   That's both incorrect and confusing. It means the user can't make a PSBT if they want to, and they might think the wallet is broken because "Send" is disabled.

   I think for external signers both buttons should be enabled, and the Create Unsigned should create a PSBT for the clipboard, not sign on the device.

7. 
   kristapsk commented at 10:05 PM on February 20, 2022: contributor

   Agree with @Sjors.

8. Sjors referenced this in commit a49bb0c832 on Feb 21, 2022
9. Sjors referenced this in commit 33d165d802 on Feb 24, 2022
10. Sjors referenced this in commit 4ed2a3bd0c on Mar 10, 2022
11. Sjors referenced this in commit 86e3e2cda8 on Mar 10, 2022
12. Sjors referenced this in commit 225794f42f on Mar 15, 2022
13. Sjors referenced this in commit 347871fd43 on Mar 15, 2022
14. Sjors referenced this in commit 0538614804 on Mar 15, 2022
15. Sjors referenced this in commit 2efdfb88aa on Mar 16, 2022
16. hebasto closed this on Mar 17, 2022

    ---

17. hebasto referenced this in commit aece566249 on Mar 17, 2022
18. bitcoin-core locked this on Mar 17, 2023

Milestone
23.0