Add and improve translator comments and tooltips for peers tab address fields #554

1. 
   jonatack commented at 10:35 pm on February 20, 2022: contributor

   Per translator feedback in this thread: #526 (review)

   “The lack of string context in Transifex is a real problem for this project, as proper context (dev notes and/or screenshots) are essential to achieve quality translations.”

   This pull adds developer notes for transifex translators via extracomment tags, and it improves the existing ones and their tooltips with more context, clarity and completeness for the following peer tab fields as a follow-up to bitcoin-core/gui#526:

   • address relay
   • addresses processed
   • addressed rate-limited

   It looks like only six lines of diff, but they are loooong lines.

   If this is the right direction, the same can be done for other fields in follow-ups.

2. in src/qt/forms/debugwindow.ui:1597 in e25e88a29f outdated

   1593@@ -1594,10 +1594,10 @@
   1594                <item row="23" column="0">
   1595                 <widget class="QLabel" name="peerAddrRelayEnabledLabel">
   1596                  <property name="toolTip">
   1597-                  <string extracomment="Tooltip text for the Address Relay field in the peer details area.">Whether we relay addresses to this peer.</string>
   1598+                  <string extracomment="Tooltip text for the Address Relay field in the peer details area, which displays whether we relay addresses to this peer (Yes/No).">Whether we relay addresses to this peer (Yes/No).</string>
   

   ---

   ---

   

   promag commented at 11:27 pm on February 21, 2022:

   Why the 2nd Yes/No?

   ---

   

   jonatack commented at 11:40 pm on February 21, 2022:

   Which one would you remove?

   ---

   

   promag commented at 11:41 pm on February 21, 2022:

   The second, leave the string unchanged.

   ---

   

   jonatack commented at 8:17 am on February 22, 2022:

   Thanks, done.
3. 
   promag commented at 11:30 pm on February 21, 2022: contributor

   Concept ACK, seems to be in line with what was suggested/requested.
4. jonatack force-pushed on Feb 22, 2022
5. 
   jonatack commented at 8:18 am on February 22, 2022: contributor

   Updated per @promag feedback (thanks!)
6. jarolrod approved
7. 
   jarolrod commented at 6:14 am on February 23, 2022: member

   ACK bcd72ef18f14d7a457db6c8b835a571dec1f2beb

   I’ve been collecting thoughts on how to formulate translator comments here and the translator comments introduced here tick the boxes.

   in reference to the translator comment documentation I’ve prepared: in 1df9daaa457a57554ba2b334f989bf5d599177bf you allude to what the value of the field is, I wonder if I should include that point as required context in the doc.

   If you retouch, and definitely not necessary, you could rename the PR to Add and improve peers tab address translator comments and tooltips and similarly update the commits to state they are updating translator comments instead of extracomment.

8. jonatack renamed this:
   Add and improve peers tab address fields dev notes and tooltips
   Add and improve peers tab address translator comments and tooltips
   on Mar 6, 2022
9. jonatack renamed this:
   Add and improve peers tab address translator comments and tooltips
   Add and improve translator comments and tooltips for peers tab address fields
   on Mar 6, 2022
10. gui: improve "Address Relay" translator comments and tooltip in peers tab 77f24aac52
11. gui: improve "Addresses Processed" translator comments and tooltip in peers tab 81ef1f7ef1
12. gui: improve "Addresses Rate-Limited" translator comments and tooltip in peers tab 4d2b503d6c
13. jonatack force-pushed on Mar 6, 2022
14. 
    jonatack commented at 4:51 pm on March 6, 2022: contributor

    ACK bcd72ef

    in reference to the translator comment documentation I’ve prepared: in 1df9daa you allude to what the value of the field is, I wonder if I should include that point as required context in the doc.

    Describing the value(s) of the field where relevant and helpful seems like a good idea. (Nice doc BTW.)

    If you retouch, and definitely not necessary, you could rename the PR to Add and improve peers tab address translator comments and tooltips and similarly update the commits to state they are updating translator comments instead of extracomment.

    Done!

15. 
    jarolrod commented at 9:28 am on March 10, 2022: member

    re-ACK 4d2b503

    Thanks for picking up the suggestions!

16. jarolrod added the label Translations on Mar 10, 2022
17. hebasto approved
18. 
    hebasto commented at 8:27 am on March 20, 2022: member

    ACK 4d2b503d6cbb593cf75cf053fd480de64b3f4fc0, I have reviewed the code and it looks OK, I agree it can be merged.
19. hebasto merged this on Mar 20, 2022
20. hebasto closed this on Mar 20, 2022

    ---

21. jonatack deleted the branch on Mar 20, 2022
22. sidhujag referenced this in commit 5714b7a26f on Mar 22, 2022
23. bitcoin-core locked this on Jun 26, 2023

Contributors
jonatack promag jarolrod hebasto

Labels
Translations