Revert “qt: Do not use QObject::tr plural syntax for numbers with a unit symbol” #557

pull luke-jr wants to merge 1 commits into bitcoin-core:master from luke-jr:gui_numeric_GBs changing 1 files +3 −3
  1. luke-jr commented at 11:14 pm on February 22, 2022: member

    Apparently this got forgotten. Maybe too late for 23.x (it’s a bugfix, but changes translation strings).

    This reverts commit 3adde72bc99215062c8dabd38f8c34ad093452b5 (#296)

    per GChuf

    I can confirm for slovenian and other slavic languages that we do have 3 or 4 different ways of saying “%n GB needed%, depending on the actual number of gigabytes. Similar to english “is/are”. There’s no way to cover all cases … this is exactly why transifex allows you to have more than 2 options.

  2. Revert "qt: Do not use QObject::tr plural syntax for numbers with a unit symbol"
    This reverts commit 3adde72bc99215062c8dabd38f8c34ad093452b5.
    0c64401324
  3. hebasto approved
  4. hebasto commented at 7:44 am on April 3, 2022: member

    ACK 0c64401324b03f5576149bf27138cdb103dae934, I have reviewed the code and it looks OK, I agree it can be merged.

    Languages indeed are so different.

  5. hebasto merged this on Apr 3, 2022
  6. hebasto closed this on Apr 3, 2022

  7. sidhujag referenced this in commit a8830ac048 on Apr 3, 2022
  8. bitcoin-core locked this on Jun 17, 2023


luke-jr hebasto


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 17:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me