Network graph improvements #559

pull rebroad wants to merge 8 commits into bitcoin-core:master from rebroad:NetworkGraphImprovements changing 9 files +409 −103
  1. rebroad commented at 9:11 pm on February 24, 2022: contributor

    This combines #492, #483, #484, and #473 and also fixes #532 by adding the ability to change between graph durations without losing the data (it’s sampled at each interval). Also added is some graphical animations when the X or Y scale changes. (it might be necessary to make this optional on lower performing hardware, such as the raspberry pi).

    One more feature is that the graph will start on the smallest duration, and automatically increase the graph duration once the graph is filled.

    Some examples can be seen in my comment at #539 (comment)

    I’m expecting there may be issues with my coding style, so I’ll create this PR as a draft at this stage.

  2. Network Graph - Create y_value function b2596f64cf
  3. Add formatBytesps function 1a6644a9ca
  4. Show ToolTip on Network Traffic graph 703e57f2be
  5. Don't clear graph when changing interval 8f033192aa
  6. Enable non-linear network traffic graph 6f70ba9105
  7. Improve formatBytes in GUI fbcf3656f7
  8. Don't lose ToolTip when toggling network graph cc4215b88d
  9. Make Network Graph sample multiple ranges 8c56419cdf
  10. rebroad force-pushed on Feb 24, 2022
  11. katesalazar commented at 9:24 pm on February 24, 2022: contributor

    What’s the rationale for combining those PRs in this one?

    On Thu, Feb 24, 2022 at 10:11 PM Rebroad @.***> wrote:

    This combines #492 https://github.com/bitcoin-core/gui/pull/492, #483 https://github.com/bitcoin-core/gui/pull/483, #484 https://github.com/bitcoin-core/gui/pull/484, and #473 https://github.com/bitcoin-core/gui/pull/473 and also adds the ability to change between graph durations without losing the data (it’s sampled at each interval). Also added is some graphical animations when the X or Y scale changes. (it might be necessary to make this optional on lower performing hardware, such as the raspberry pi).

    Some examples can be seen in my comment at #539 (comment) https://github.com/bitcoin-core/gui/pull/539#issuecomment-1031852315

    I’m expecting there may be issues with my coding style, so I’ll create this PR as a draft at this stage.

    You can view, comment on, or merge this pull request online at:

    #559 Commit Summary

    File Changes

    (9 files https://github.com/bitcoin-core/gui/pull/559/files)

    Patch Links:

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/pull/559, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W3BURANHIF5WEZW3NLU42NIFANCNFSM5PIP6G4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

    You are receiving this because you are subscribed to this thread.Message ID: @.***>

  12. rebroad commented at 9:34 pm on February 24, 2022: contributor

    What’s the rationale for combining those PRs in this one?

    Because they are difficult to separate - given they each kinda tread on the toes of the others, I thought better to PR the whole foot rather than the individual toes. e.g. more than one feature uses the y_value() function, the tool-tip change and the linear/non-linear change both need an extra commit to be able work together.

  13. DrahtBot commented at 5:40 am on February 25, 2022: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #540 (network graph - show/hide panels based on window width/height by RandyMcMillan)
    • #483 (Make network graph slider easier to use by rebroad)
    • #473 (Enable a non-linear network traffic option (click to toggle between linear and non-linear) by rebroad)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  14. jarolrod added the label UI on Mar 10, 2022
  15. jarolrod added the label UX on Mar 10, 2022
  16. rebroad marked this as ready for review on Jul 27, 2022
  17. katesalazar commented at 7:25 pm on September 18, 2022: contributor

    This was a bad idea. If there wasn’t enough developer time to review your scattered PRs, a larger combined PR shall only have larger reviewing problems. I’d suggest choosing one of your small PRs and to pay for reviews. Get it definitely NACKed or ACKed and merged, then repeat with a different PR. Choose PR order wisely. Good luck!

    On Thu, Feb 24, 2022 at 10:34 PM Rebroad @.***> wrote:

    What’s the rationale for combining those PRs in this one?

    Because they are difficult to separate - given they each kinda tread on the toes of the others, I thought better to PR the whole foot rather than the individual toes. e.g. more than one feature uses the y_value() function, the tool-tip change and the linear/non-linear change both need an extra commit to be able work together.

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/pull/559#issuecomment-1050287182, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W3MP43PNFYLTSFJKMDU42P55ANCNFSM5PIP6G4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

    You are receiving this because you commented.Message ID: @.***>

  18. DrahtBot added the label Needs rebase on Oct 3, 2022
  19. DrahtBot commented at 12:42 pm on October 3, 2022: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

  20. DrahtBot commented at 1:44 am on January 1, 2023: contributor

    There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
  21. hebasto commented at 3:16 pm on March 27, 2023: member
    Closing this due to lack of activity. Feel free to reopen.
  22. hebasto closed this on Mar 27, 2023
  23. bitcoin-core locked this on Mar 26, 2024


rebroad katesalazar DrahtBot hebasto

Labels
Needs rebase UX UI

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-23 00:20 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me