qt: Equalize notifySystray and notifyDBus interface #574

1. 
   laanwj commented at 2:50 pm on April 4, 2022: member

   Make notifySystray and notifyDBus feature-equivalent by making notifySystray support custom icons. This uses the QSystemTrayIcon::showMessage overload introduced in Qt 5.9.

   This is an initial step towards bitcoin-core/gui#573.

2. qt: Equalize notifySystray and notifyDBus interface

   Equalize the `notifySystray` and `notifyDBus` interface with regard to
   features by making `notifySystray` support custom icons. This uses the
   `QSystemTrayIcon::showMessage` overload introduced in Qt 5.9.
   
   This is an initial step towards bitcoin-core/gui#573.

   9723b29c13
3. laanwj added the label Feature on Apr 4, 2022
4. laanwj added the label Linux on Apr 4, 2022
5. laanwj removed the label Linux on Apr 6, 2022
6. 
   laanwj commented at 10:15 am on April 6, 2022: member

   I guess the best way of testing this on Linux is to comment out the DBUS notificator code. And generate notifications somehow.

   Also, it should be tested on Windows. DBUS is irrelevant on Windows, but the QTrayIcon code is used there. Removed the Linux label.

   Edit: re-pushed so it compiles on non-Linux

7. 
   laanwj commented at 4:15 pm on April 6, 2022: member

   Closing, it looks like we’re not using the custom icon functionality at all. Will remove instad.
8. laanwj closed this on Apr 6, 2022

   ---

9. bitcoin-core locked this on Apr 6, 2023

Contributors
laanwj

Labels
Feature