Getting ready to Qt 6 (1/n) #577

1. 
   hebasto commented at 11:33 pm on April 8, 2022: member

   For Qt 5 all changes in this PR are refactoring. But for Qt 6 they are real bugfixes :)

   As I do not provide anyway way to build bitcoin-qt against Qt 6.2.4 fir now, suggesting to reviewers to verify changes for Qt 5 only.

2. qt: Fix headers

   This change is preparation for Qt 6, and it fixes an experimental build
   with Qt 6.2.4.

   6f1e162fe1
3. qt: Use `|` instead of `+` for key modifiers

   This change is preparation for Qt 6 where `+` has been deprecated, and
   it fixes an experimental build with Qt 6.2.4.

   c7add881a6
4. qt: Update deprecated enum value

   This change is preparation for Qt 6, and it fixes an experimental build
   with Qt 6.2.4.
   The `Qt::ItemIsTristate` value has been deprecated since 5.6.0 (see
   ae8406d82f541f6d9112bdac192e5e4e114d56aa upstream commit).

   63125752a9
5. shaavan approved
6. 
   shaavan commented at 4:42 pm on April 10, 2022: contributor

   ACK 63125752a902de725f8aad1ee5bdaf5cb0c70f91

   Going commit wise:

   1. The first commit removes that unnecessary importing of the <QActionGroup> library in the walletview.cpp file where it was unused and add an appropriate import statement in bitcoingui.cpp where it is being used in the file. guiutil.cpp is using the QStandardPaths library. Hence, it is also appropriately imported into this PR.
   2. I successfully verified that the “+” is deprecated for the QKeySequence function in Qt 6. I have attached a reference screenshot from the official Qt 6 documentation.

   

   3. I was able to verify that this Qt::ItemIsTristate is deprecated, and Qt::ItemIsAutoTristate replaces its usage. I am attaching a reference screenshot from Qt 5 documentation.

   

   I successfully compiled and ran the bitcoin core GUI from this PR without any errors or warnings.

7. jarolrod approved
8. 
   jarolrod commented at 2:50 am on April 12, 2022: member

   tACK https://github.com/bitcoin-core/gui/commit/63125752a902de725f8aad1ee5bdaf5cb0c70f91

   Tested changes on linux, macOS, and windows. Confirmed no change in behavior and confirmed deprecation statuses with Qt docs

9. hebasto added the label Qt 6 on Apr 12, 2022
10. hebasto merged this on Apr 12, 2022
11. hebasto closed this on Apr 12, 2022

    ---

12. hebasto deleted the branch on Apr 13, 2022
13. sidhujag referenced this in commit 2a28cec94f on Apr 13, 2022
14. bitcoin-core locked this on Apr 13, 2023

Contributors
hebasto shaavan jarolrod

Labels
Qt 6