Tor status indicator icon in bottom right #58

1. 
   fanquake commented at 10:11 am on August 14, 2020: member

   Moved from: https://github.com/bitcoin/bitcoin/issues/7734.

   The current QT GUI shows some network status indicators in the bottom right.

   I’d like someone to add one for Tor. It might be the Tor onion logo that is either green, yellow (if going through some not-quite-ready stage) or with a circle and line striking through it when not connected via Tor.

   This would complement the Tor-related improvements in 0.12.0 and make it easier for users to determine whether they are connected via Tor without doing additional investigatory steps, such as using the -debug=tor switch.

2. fanquake added the label Feature on Aug 14, 2020
3. 
   jonatack commented at 10:41 am on August 14, 2020: contributor

   Concept ACK
4. 
   jonatack commented at 9:20 am on August 20, 2020: contributor

   Nice!
5. 
   michaelfolkson commented at 9:49 am on August 20, 2020: member

   I like the minimalism, I think that is important for Core. The “Not connected” icon and “connected” icons are clear. Maybe the “connecting” icon could be fainter. Similar to the “Not connected icon” but without the cross.
6. 
   MarcoFalke commented at 5:20 am on August 21, 2020: contributor

   Why not pick the icons that look good even when scaled down (non high-DPI displays)?

   Tor made an effort and recently changed those: https://trac.torproject.org/projects/tor/ticket/25702

   

7. 
   Bosch-0 commented at 6:16 am on August 21, 2020: none

   Why not pick the icons that look good even when scaled down (non high-DPI displays)?

   SVG will look fine when scaled down or up

8. 
   MarcoFalke commented at 6:25 am on August 21, 2020: contributor

   When rendering an SVG, there will always be a limit until it can no longer be scaled down and still be distinguished from a blurry blob. Generally, the less detail an SVG has, the less pixels are needed to still represent the details.
9. 
   Bosch-0 commented at 10:08 am on August 21, 2020: none

   I’ll look at what Tor has done, can always have different icon sizes in the repo - the ones I uploaded in my PR are 128 x 128 same as the other icons use in the bottom menu.
10. 
    hebasto commented at 5:59 pm on September 1, 2020: member

    Should we distinguish “node has a Tor network connection” and “node has only Tor network connection”? The former could lead an unexperienced user to a false sense of privacy.

    Also “listening to Tor” (inbound connections) and “connecting to Tor” (outbound connections) are controlled by different options, and it means there are 4 different states of the node. I think Tor icons should cope them all, no?

11. 
    Sjors commented at 6:34 pm on September 2, 2020: member

    It might make sense to show no icon at all if there’s no Tor connection.

    When we do show an icon, I suggest only showing that when the connection is actually secure:

    1. all outbound connections go through Tor; and
    2. inbound connections are disabled, or are through Tor

    In particular, there’s not much privacy benefit in connecting to some nodes via Tor and some nodes via plain internet.

    This approach makes the “connecting” icon unnecessary, because we already have an indicator for connectivity in general.

12. 
    Bosch-0 commented at 9:19 am on September 8, 2020: none

    New designs using only one icon based on feedback. If the icon is clicked the user should be re-directed to the ‘Network’ tab in settings -> options.

    

    Tor tooltip.

    If the user is connecting through a Tor proxy (and not a IPv4 or IPv4 one) should the proxy ‘P’ icon in the bottom right be shown still? Based on my understanding I think not but am not sure if they have separate technical reasons for showing both.

    Figma source files for icon Figma source files for designs

13. 
    hebasto commented at 2:28 pm on September 9, 2020: member

    @Bosch-0 @Sjors Please review https://github.com/bitcoin/bitcoin/pull/19926
14. 
    hebasto commented at 8:40 am on September 10, 2020: member

    @Bosch-0 @Sjors Please review bitcoin/bitcoin#19926

    The PR has been moved into this repo: #86.

Contributors
fanquake jonatack michaelfolkson MarcoFalke Bosch-0 hebasto Sjors

Labels
Feature