refactor: Replace GUIUtil::ObjectInvoke() with QMetaObject::invokeMethod() #587

1. 
   hebasto commented at 5:27 pm on April 16, 2022: member

   A comment in 5659e73493fcdfb5d0cb9d686c24c4fbe1c217ed states that GUIUtil::ObjectInvoke

   can be replaced by a call to the QMetaObject::invokeMethod functor overload after Qt 5.10

2. qt: Replace `GUIUtil::ObjectInvoke()` with `QMetaObject::invokeMethod()`

   The `GUIUtil::ObjectInvoke()` template function was a replacement of
   the `QMetaObject::invokeMethod()` functor overload which is available
   in Qt 5.10+.
   
   No behavior change.

   249984f4f9
3. Revert "qt: Add ObjectInvoke template function"

   This reverts commit 5659e73493fcdfb5d0cb9d686c24c4fbe1c217ed.

   6958a26aa1
4. hebasto added the label Refactoring on Apr 16, 2022
5. 
   prusnak commented at 5:36 pm on April 16, 2022: contributor

   Approach ACK
6. 
   DrahtBot commented at 4:17 am on April 17, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #417 (Ditch wallet model juggling by promag)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. w0xlt approved
8. 
   w0xlt commented at 2:48 pm on April 19, 2022: contributor

   tACK https://github.com/bitcoin-core/gui/pull/587/commits/6958a26aa136e0976870237ccc6ea015d113f7ac on Ubuntu 21.10, Qt 5.15.2.
9. 
   promag commented at 4:46 pm on April 19, 2022: contributor

   Code review ACK 6958a26aa136e0976870237ccc6ea015d113f7ac.
10. hebasto merged this on Apr 22, 2022
11. hebasto closed this on Apr 22, 2022

    ---

12. hebasto deleted the branch on Apr 22, 2022
13. sidhujag referenced this in commit 99f37f1fb5 on Apr 22, 2022
14. bitcoin-core locked this on Apr 22, 2023

Contributors
hebasto prusnak DrahtBot w0xlt promag

Labels
Refactoring