A comment in 5659e73493fcdfb5d0cb9d686c24c4fbe1c217ed states that GUIUtil::ObjectInvoke
can be replaced by a call to the QMetaObject::invokeMethod functor overload after Qt 5.10
refactor: Replace `GUIUtil::ObjectInvoke()` with `QMetaObject::invokeMethod()` #587
pull hebasto wants to merge 2 commits into bitcoin-core:master from hebasto:220416-invoke510 changing 3 files +5 −16-
hebasto commented at 5:27 PM on April 16, 2022: member
-
249984f4f9
qt: Replace `GUIUtil::ObjectInvoke()` with `QMetaObject::invokeMethod()`
The `GUIUtil::ObjectInvoke()` template function was a replacement of the `QMetaObject::invokeMethod()` functor overload which is available in Qt 5.10+. No behavior change.
-
6958a26aa1
Revert "qt: Add ObjectInvoke template function"
This reverts commit 5659e73493fcdfb5d0cb9d686c24c4fbe1c217ed.
- hebasto added the label Refactoring on Apr 16, 2022
-
prusnak commented at 5:36 PM on April 16, 2022: contributor
Approach ACK
-
DrahtBot commented at 4:17 AM on April 17, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #417 (Ditch wallet model juggling by promag)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- w0xlt approved
-
w0xlt commented at 2:48 PM on April 19, 2022: contributor
tACK https://github.com/bitcoin-core/gui/pull/587/commits/6958a26aa136e0976870237ccc6ea015d113f7ac on Ubuntu 21.10, Qt 5.15.2.
-
promag commented at 4:46 PM on April 19, 2022: contributor
Code review ACK 6958a26aa136e0976870237ccc6ea015d113f7ac.
- hebasto merged this on Apr 22, 2022
- hebasto closed this on Apr 22, 2022
- hebasto deleted the branch on Apr 22, 2022
- sidhujag referenced this in commit 99f37f1fb5 on Apr 22, 2022
- bitcoin-core locked this on Apr 22, 2023
