AddressBookPage
#592
Wildcard support for address/label search in AddressBookPage was introduced in bitcoin/bitcoin#12080, and it is available in release binaries since v0.17.
But this feature has never being documented or mentioned in the GUI.
Thus, there are no reasons to believe that users rely on this feature.
Required for migration to Qt 6, because:
There is no direct way to do wildcard matching in
QRegularExpression.
Tests included.
~Based on bitcoin-core/gui#591, so only last 2 commits belong to this PR.~
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
QRegularExpression in AddressBookSortFilterProxyModel class by hebasto)If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
“However, the wildcardToRegularExpression method is provided to translate glob patterns into a Perl-compatible regular expression that can be used for that purpose.”
Seems like it should be trivial to retain this feature, if we want to?
Such support was never mentioned in release notes or in the GUI.
Required for migration to Qt 6, because "There is no direct way to do
wildcard matching in QRegularExpression."
See https://doc.qt.io/qt-6/qregexp.html#porting-to-qregularexpression
“However, the wildcardToRegularExpression method is provided to translate glob patterns into a Perl-compatible regular expression that can be used for that purpose.”
Seems like it should be trivial to retain this feature, if we want to?
Would you mind provide a working example please?
139@@ -143,7 +140,9 @@ void AddressBookPage::setModel(AddressTableModel *_model)
140 proxyModel = new AddressBookSortFilterProxyModel(type, this);
141 proxyModel->setSourceModel(_model);
142
143- connect(ui->searchLineEdit, &QLineEdit::textChanged, proxyModel, &QSortFilterProxyModel::setFilterWildcard);
144+ connect(ui->searchLineEdit, &QLineEdit::textChanged, [this](const QString& pattern) {
145+ proxyModel->setFilterFixedString(pattern);
In fact setFilterWildcard in Qt6 already handles the change noted in the porting documentation:
There is no direct way to do wildcard matching in QRegularExpression. However, the wildcardToRegularExpression method is provided to translate glob patterns into a Perl-compatible regular expression that can be used for that purpose.
Qt5
0void QSortFilterProxyModel::setFilterFixedString(const QString &pattern)
1{
2 Q_D(QSortFilterProxyModel);
3 d->filter_about_to_be_changed();
4 QRegExp rx(pattern, d->filter_data.caseSensitivity(), QRegExp::FixedString);
5 d->filter_data.setRegExp(rx);
6 d->filter_changed();
7}
Qt6
0void QSortFilterProxyModel::setFilterWildcard(const QString &pattern)
1{
2 Q_D(QSortFilterProxyModel);
3 d->filter_regularexpression.removeBindingUnlessInWrapper();
4 d->filter_about_to_be_changed();
5 d->set_filter_pattern(QRegularExpression::wildcardToRegularExpression(
6 pattern, QRegularExpression::UnanchoredWildcardConversion));
7 d->filter_changed(QSortFilterProxyModelPrivate::Direction::Rows);
8 d->filter_regularexpression.notify();
9}
Tested ACK 555b673fbc71412908bb73c9c71d49895270335f.
TBH I didn’t think about using a wildcard in the search field, so setFilterFixedString would be sufficient.
The only issue I have is breaking someone’s expectation, as this is a breaking change - using wildcard results in an empty list where before it could list some addresses. I understand it’s not documented but it’s available for some time. Maybe could validate the search field to disallow wildcard, like:
0yle, Mode _mode,
1 {
2 ui->setupUi(this);
3
4+ auto validator = new QRegularExpressionValidator(QRegularExpression("[^\\*]*"), this);
5+ ui->searchLineEdit->setValidator(validator);
6+
7 if (!platformStyle->getImagesOnButtons()) {
8 ui->newAddress->setIcon(QIcon());
9 ui->copyAddress->setIcon(QIcon());
Finally, if we stick to supporting wildcard then no changes are required as explained in the comment below (but didn’t test with Qt6).