Translate unit names & fix external signer error #599

1. 
   luke-jr commented at 10:32 pm on May 15, 2022: member

   I think I got everything under src/qt missing translatability.

   Exceptions:

   • Punctuation-only (this is a can of worms)
   • Date/time (long-standing ignoring of locale, not sure anyone minds)
   • Obscure errors
   • Technical terms in transactiondesc

   Notably, I did include units. Not only for the benefit of non-Latin languages, but also we have “bits” and “sats” nowadays that likely make sense to translate even in Latin-based languages.

   (Much of this was merged in #724 already)

2. Jilasoon changes_requested
3. 
   Jilasoon commented at 11:10 pm on May 15, 2022: none

   .
4. hebasto added the label Translations on May 20, 2022
5. 
   hebasto commented at 10:26 pm on June 1, 2022: member

   Concept ACK.
6. 
   katesalazar commented at 11:51 am on June 3, 2022: contributor

   great idea
7. 
   DrahtBot commented at 9:44 pm on June 12, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept ACK	hebasto, furszy

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #bitcoin/bitcoin/29015 (kernel: Streamline util library by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. 
   furszy commented at 0:59 am on July 1, 2022: member

   Concept ACK and initial code review ACK 5e23dabf2

   As it has a good number of changes, will give it another look in the coming days.

9. DrahtBot added the label Needs rebase on Aug 8, 2022
10. 
    luke-jr commented at 3:43 am on September 3, 2022: member

    Rebased (no changes, just had to re-generate the make translate outputs)
11. luke-jr force-pushed on Sep 3, 2022
12. DrahtBot removed the label Needs rebase on Sep 3, 2022
13. DrahtBot added the label Needs rebase on Sep 14, 2022
14. 
    hebasto commented at 1:32 pm on February 27, 2023: member

    Concept ACK.

    Concept ACK and initial code review ACK 5e23dab @luke-jr

    Mind rebasing this PR before soft translation string freeze?

15. in src/qt/bitcoinunits.cpp:67 in 7ec30cf012 outdated

    74-    case Unit::uBTC: return QString("Micro-Bitcoins (bits) (1 / 1" THIN_SP_UTF8 "000" THIN_SP_UTF8 "000)");
    75-    case Unit::SAT: return QString("Satoshi (sat) (1 / 100" THIN_SP_UTF8 "000" THIN_SP_UTF8 "000)");
    76+    //: Tooltip description of "BTC" unit in dropbox selector
    77+    case Unit::BTC: return tr("Bitcoins", "unit description");
    78+    //: Tooltip description of "mBTC" unit in dropbox selector
    79+    case Unit::mBTC: return tr("Milli-Bitcoins (1 / 1" THIN_SP_UTF8 "000)", "unit description");
    

    ---

    ---

    

    hebasto commented at 11:32 am on March 31, 2023:

    2e55d10ac487c2799c4530a7bec8767f1b2303e4

    It seems not passing to the translation file properly.

16. hebasto referenced this in commit bc49a477de on Apr 1, 2023
17. 
    hebasto commented at 9:09 pm on April 1, 2023: member

    Most of commits from this PR were merged as a part of #724.
18. luke-jr force-pushed on Jun 29, 2023
19. luke-jr renamed this:
    Translatability fixups
    Translate unit names & fix external signer error
    on Jun 29, 2023
20. 
    luke-jr commented at 10:02 pm on June 29, 2023: member

    Rebased. Only units and the external signer bugfix remain. I didn’t regenerate translations this time.
21. Bugfix: GUI: Display error messagebox (rather than stderr) when external signer fails inexplicably f4fe307b84
22. GUI: Support translating Bitcoin units d941132406
23. luke-jr force-pushed on Jun 29, 2023
24. DrahtBot removed the label Needs rebase on Jun 30, 2023
25. DrahtBot added the label CI failed on Aug 18, 2023
26. DrahtBot removed the label CI failed on Aug 23, 2023
27. DrahtBot added the label CI failed on Aug 31, 2023
28. DrahtBot removed the label CI failed on Sep 4, 2023
29. DrahtBot added the label CI failed on Sep 4, 2023
30. DrahtBot removed the label CI failed on Sep 6, 2023
31. DrahtBot added the label CI failed on Oct 25, 2023
32. DrahtBot added the label Needs rebase on Jun 12, 2024
33. 
    DrahtBot commented at 10:24 pm on June 12, 2024: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

34. 
    DrahtBot commented at 1:14 am on September 9, 2024: contributor

    ⌛ There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
35. 
    DrahtBot commented at 1:30 am on December 7, 2024: contributor

    ⌛ There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.

Contributors
luke-jr Jilasoon hebasto katesalazar DrahtBot furszy

Labels
Needs rebase Translations CI failed