refactor: Drop unused QFrames in SendCoinsEntry #612

1. 
   hebasto commented at 5:44 pm on May 30, 2022: member

   The SendCoins_UnauthenticatedPaymentRequest and SendCoins_AuthenticatedPaymentRequest sub-QFrame’s of the SendCoinsEntry widget have been unused since bitcoin/bitcoin#17165.

   Removed all dead code. The resulted SendCoinsEntry widget has been simplified.

2. qt, refactor: Drop unused `QFrame`s in `SendCoinsEntry` 6420fb2005
3. hebasto added the label Refactoring on May 30, 2022
4. hebasto added the label UI on May 30, 2022
5. 
   DrahtBot commented at 3:14 am on May 31, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #560 (Make error message layout consistent by w0xlt)
   • #534 (Add translatable address error message by w0xlt)
   • #533 (Add more detailed address error message by w0xlt)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. furszy approved
7. 
   furszy commented at 3:06 pm on June 8, 2022: contributor

   Code reviewed ACK a57cd028

   No functional changes.

8. in src/qt/sendcoinsentry.h:25 in a57cd028f5 outdated

   24@@ -25,7 +25,7 @@ namespace Ui {
   25  * Stacked widget, with different UIs for payment requests
   

   ---

   ---

   

   laanwj commented at 3:30 pm on June 8, 2022:

   Please change the comment too

   ---

   

   hebasto commented at 11:45 am on June 12, 2022:

   @laanwj

   Thank you! Updated.

9. 
   laanwj commented at 3:30 pm on June 8, 2022: member

   Concept ACK, nice cleanup
10. shaavan approved
11. 
    shaavan commented at 8:49 am on June 11, 2022: contributor

    ACK a57cd028f5354e0fcc872aca6358ef7b1287b191

    • This PR does an excellent clean-up to sendcoinentry.ui file by:

      • Removing no longer used code.
      • Simplifying the widget type for the updated UI elements.
      • Fixing indentations.
      • Fixing the parent class for the BitcoinAmountField widget.

    • I was able to successfully compile and run this PR on Ubuntu 22.04 with Qt version 5.15.3

    • I observed no functional or behavioral changes in the GUI.

    As @laanwj rightly pointed out. The comment mentioning “Stacked widget” shall also be removed.

12. qt, refactor: Convert `SendCoinsEntry` to a sub-`QWidget`

    It is no longer needed to derive the `SendCoinsEntry` class from the
    `QStackedWidget` one.

    f3c7603329
13. qt, refactor: Fix `sendcoinsentry.ui` indentation 3262542104
14. qt: Fix `BitcoinAmountField`'s base widget 7ab72b9d2a
15. hebasto force-pushed on Jun 12, 2022
16. 
    hebasto commented at 11:44 am on June 12, 2022: member

    Updated a57cd028f5354e0fcc872aca6358ef7b1287b191 -> 7ab72b9d2a500420a1103221c3cbfac4cda1c43a (pr612.01 -> pr612.02, diff):

    • addressed @laanwj’s comment
17. w0xlt approved
18. 
    w0xlt commented at 3:15 am on June 13, 2022: contributor

    Tested ACK https://github.com/bitcoin-core/gui/pull/612/commits/7ab72b9d2a500420a1103221c3cbfac4cda1c43a
19. shaavan approved
20. 
    shaavan commented at 8:48 am on June 20, 2022: contributor

    reACK 7ab72b9d2a500420a1103221c3cbfac4cda1c43a

    Changes since my last review:

    • @laanwj’s comment is rightly addressed.

    I searched for comments mentioning “Stacked …” in src/qt/sendcoinsentry.* files, and I found none. This shows that all these comments are appropriately removed.

21. hebasto merged this on Jun 21, 2022
22. hebasto closed this on Jun 21, 2022

    ---

23. hebasto deleted the branch on Jun 21, 2022
24. sidhujag referenced this in commit 241fbd058b on Jun 21, 2022
25. bitcoin-core locked this on Jun 21, 2023

Contributors
hebasto DrahtBot furszy laanwj shaavan w0xlt

Labels
Refactoring UI