Minor Formatting Fixes #638

1. 
   2140data commented at 6:10 pm on August 3, 2022: none

   Update receivecoinsdialog.ui - Line 73 - Adding a whitespace character ( ) on the QT Receive Coins form instructions in order to show a space after the period in the application.

   Update sendcoinsdialog.ui - Line 120 - Adding Sentence case to the label to maintain consistency

2. Update receivecoinsdialog.ui

   Line 73 - Adding a whitespace character ( ) on the QT Receive Coins form instructions in order to show a space after the period in the application.

   67fc2cc684
3. Update sendcoinsdialog.ui

   Line 120 - Adding Sentence case to the label to maintain consistency

   2f8ec3b30f
4. 
   jarolrod commented at 11:05 pm on August 9, 2022: member

   This is a bug in Qt where it sets the advance or width of the space character very low if it is preceded by a comma or period when running on macOS. It doesn’t affect Linux or Windows. Additionally it only affects users on macOS with Qt less than 5.15.3 who are compiling the gui on their own. See: https://bugreports.qt.io/browse/QTBUG-88495

   This has been fixed in Qt 5.15.3, we build our releases with Qt 5.15.5 now, and so this issue won’t be seen with the release binary. I have confirmed this myself now by guix building this PR and master and testing it on macOS, the master branch built with Qt 5.15.5 does not show the space issue.

   I think it’s fine to change the spaces that are preceeded by a comma or period to “ ”, this would be fixing the issue specifically for users who are compiling the gui on their own and on macOS; we would want to do it everywhere else this formatting bug exists.

   It should be noted this can be a can of worms if we are changing translatable strings to include these seemingly foreign string of characters. It can trip up translators and they could remove it from their translations. Unless transifex automatically excludes these characters (cc @hebasto).

5. 
   luke-jr commented at 2:37 am on August 10, 2022: member

   Concept NACK.

   The best place for a break (if needed) is between sentences. So keeping a normal space there is preferable. We don’t need to workaround bugs in other software for something so minor that doesn’t even effect the current version, especially when the workaround is semantically incorrect.

   As for the “automatically selected”, I think it actually looks better lowercased.

6. 
   2140data commented at 6:36 pm on August 10, 2022: none

   Thank you. I see your points. No space is apparent between the sentences on the Mac, but it’s not a big deal in the end (as noted). Maybe \u0020 would be more correct if such a change was desired. Closing.
7. 2140data closed this on Aug 10, 2022

   ---

8. 
   2140data commented at 6:47 pm on August 10, 2022: none

   Example of the issue, this time on the Welcome screen.

9. 
   hebasto commented at 8:15 pm on August 10, 2022: member

   @2140data

   Example of the issue, this time on the Welcome screen.

   Please provide more details about bitcoin-qt binary you run. Version (if downloaded) or commit (if self-compiled)?

10. hebasto added the label macOS on Aug 10, 2022
11. 
    2140data commented at 3:34 pm on August 11, 2022: none

    Thank you. Apologies for not adding these details sooner.

    • Mac OS Monterey 12.4
    • Bitcoin Core download Version 22.0.0
12. 
    hebasto commented at 5:50 pm on August 11, 2022: member

    Bitcoin Core v22.0 GUI uses Qt 5.12.11. It indeed has a bug.

    You could use Bitcoin Core v23.0 uses Qt 5.15.2. But the bug has been fixed only in Qt 5.15.3.

    Probably, we should bump Qt for v23.1.

    ---

    Also see bitcoin/bitcoin#24939.

13. 
    2140data commented at 6:10 pm on August 11, 2022: none

    Thank you everyone for your time and review.
14. hebasto cross-referenced this on Aug 12, 2022 from issue [23.x] GUI backports by hebasto
15. hebasto cross-referenced this on Aug 12, 2022 from issue build, qt: bump Qt5 version to 5.15.3 by prusnak
16. fanquake referenced this in commit 45c9f4afa4 on Oct 2, 2022
17. bitcoin-core locked this on Aug 11, 2023

Contributors
2140data jarolrod luke-jr hebasto

Labels
macOS