Prevent wrong handling of %2 token by Transifex #664

1. 
   hebasto commented at 9:06 am on September 7, 2022: member

   On master (124e75a41ea0f3f0e90b63b0c41813184ddce2ab), Transifex translation check fails for https://github.com/bitcoin-core/gui/blob/124e75a41ea0f3f0e90b63b0c41813184ddce2ab/src/qt/forms/intro.ui#L206 with a message:

   The expression ‘%2G’ is not present in the translation.

   In “Organization Settings” –> “Translation checks” I have changed the status of the “Variable substitution specifiers (like “%s”) are preserved in the translations.” check from “error” to “warning” temporarily. This setting should be reverted after applying this PR change.

   Noted by Transifex user AHOHNMYC.

   I faced the same issue while working on Ukrainian translation.

2. qt: Prevent wrong handling of `%2` token by Transifex

   Transifex must expect a `%2` token in the translated string, not a
   `%2GB` one.

   8ed2b72767
3. hebasto added the label Translations on Sep 7, 2022
4. 
   hebasto commented at 9:07 am on September 7, 2022: member

   cc @luke-jr @wtogami @jarolrod
5. luke-jr approved
6. 
   luke-jr commented at 8:17 pm on September 7, 2022: member

   ACK
7. 
   katesalazar commented at 10:07 pm on September 7, 2022: contributor

   ACK 8ed2b72767de55dce033d8bfe6f9414ae14e1452

   replace " GB" for “GB” (only here) after it is translated?

8. 
   luke-jr commented at 10:16 pm on September 7, 2022: member

   replace " GB" for “GB” (only here) after it is translated?

   Why? There is supposed to be a space…?

9. jarolrod approved
10. 
    jarolrod commented at 2:59 am on September 9, 2022: member

    ACK 8ed2b72767de55dce033d8bfe6f9414ae14e1452
11. 
    katesalazar commented at 2:35 pm on September 9, 2022: contributor

    I wasn’t sure before, but yeah, it seems there is supposed to be a space. 👍

    On Thu, Sep 8, 2022 at 12:16 AM Luke Dashjr @.***> wrote:

    replace " GB" for “GB” (only here) after it is translated?

    Why? There is supposed to be a space…?

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/pull/664#issuecomment-1239961391, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W4EI2QBSAXABKBI7PDV5EH3DANCNFSM6AAAAAAQGR5QKU . You are receiving this because you commented.Message ID: @.***>

12. hebasto merged this on Sep 14, 2022
13. hebasto closed this on Sep 14, 2022

    ---

14. hebasto deleted the branch on Sep 14, 2022
15. sidhujag referenced this in commit 2ff170643f on Sep 14, 2022
16. hebasto referenced this in commit d190003700 on Sep 14, 2022
17. 
    katesalazar commented at 8:06 am on October 11, 2022: contributor

    I wasn’t sure before, but yeah, it seems there is supposed to be a space. 👍

    On Thu, Sep 8, 2022 at 12:16 AM Luke Dashjr @.***> wrote:

    replace " GB" for “GB” (only here) after it is translated?

    Why? There is supposed to be a space…?

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/pull/664#issuecomment-1239961391, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W4EI2QBSAXABKBI7PDV5EH3DANCNFSM6AAAAAAQGR5QKU . You are receiving this because you commented.Message ID: @.***>

18. bitcoin-core locked this on Oct 11, 2023

Contributors
hebasto luke-jr katesalazar jarolrod

Labels
Translations