[WIP] GUI: exception safe drop-in replacement for QTimer::singleShot #666

pull furszy wants to merge 2 commits into bitcoin-core:master from furszy:2022_gui_safe_connect_qtimer changing 3 files +62 −27
  1. furszy commented at 0:35 am on September 11, 2022: member

    Based on a convo originated in #26005.

    Catch unexpected exceptions originated in QTimer::SingleShot lambda slots at the GUI level.

  2. GUI: implement ExceptionSafeConnectWorker
    A drop-in replacement of QObject::connect(Object* sender, Func1 signal, Object* context, Func2 slot) function
    
    The "context" object defines in which event loop the function will be executed.
    eece08c703
  3. GUI: exception safe drop-in replacement for QTimer::singleShot 262112b889
  4. furszy renamed this:
    GUI: exception safe drop-in replacement for QTimer::singleShot
    [WIP] GUI: exception safe drop-in replacement for QTimer::singleShot
    on Sep 11, 2022
  5. furszy marked this as a draft on Sep 11, 2022
  6. DrahtBot added the label Needs rebase on Sep 16, 2022
  7. DrahtBot commented at 12:19 pm on September 16, 2022: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

  8. DrahtBot commented at 0:45 am on December 15, 2022: contributor

    There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
  9. DrahtBot commented at 0:33 am on March 15, 2023: contributor

    There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
  10. hebasto commented at 1:38 pm on March 27, 2023: member
    Closing this due to lack of activity. Feel free to reopen.
  11. DrahtBot commented at 1:38 pm on March 27, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  12. hebasto closed this on Mar 27, 2023

  13. bitcoin-core locked this on Mar 26, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-23 00:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me