Based on a convo originated in #26005.
Catch unexpected exceptions originated in QTimer::SingleShot lambda slots at the GUI level.
[WIP] GUI: exception safe drop-in replacement for QTimer::singleShot #666
pull furszy wants to merge 2 commits into bitcoin-core:master from furszy:2022_gui_safe_connect_qtimer changing 3 files +62 −27-
furszy commented at 12:35 AM on September 11, 2022: member
-
eece08c703
GUI: implement ExceptionSafeConnectWorker
A drop-in replacement of QObject::connect(Object* sender, Func1 signal, Object* context, Func2 slot) function The "context" object defines in which event loop the function will be executed.
-
GUI: exception safe drop-in replacement for QTimer::singleShot 262112b889
- furszy renamed this:
GUI: exception safe drop-in replacement for QTimer::singleShot
[WIP] GUI: exception safe drop-in replacement for QTimer::singleShot
on Sep 11, 2022 - furszy marked this as a draft on Sep 11, 2022
- DrahtBot added the label Needs rebase on Sep 16, 2022
-
DrahtBot commented at 12:19 PM on September 16, 2022: contributor
<!--cf906140f33d8803c4a75a2196329ecb-->
🐙 This pull request conflicts with the target branch and needs rebase.
<sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>
-
DrahtBot commented at 12:45 AM on December 15, 2022: contributor
<!--13523179cfe9479db18ec6c5d236f789-->
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
- Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
- Is it no longer relevant? ➡️ Please close.
- Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.
-
DrahtBot commented at 12:33 AM on March 15, 2023: contributor
<!--13523179cfe9479db18ec6c5d236f789-->
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
- Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
- Is it no longer relevant? ➡️ Please close.
- Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.
-
hebasto commented at 1:38 PM on March 27, 2023: member
Closing this due to lack of activity. Feel free to reopen.
-
DrahtBot commented at 1:38 PM on March 27, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
- hebasto closed this on Mar 27, 2023
- bitcoin-core locked this on Mar 26, 2024
Labels