Fix Transaction Relay tooltip text in Peers details window #681
pull jonatack wants to merge 1 commits into bitcoin-core:master from jonatack:relaytxes-tooltip-fix changing 1 files +1 −1-
jonatack commented at 4:57 am on November 17, 2022: contributoras a value of N/A could occur due to a lock or a disconnection race but not during connection setup – see https://github.com/bitcoin/bitcoin/pull/26457#pullrequestreview-1181641835. Credit to Martin Zumsande for finding this.
-
Fix Transaction Relay tooltip text in Peers details window
as a value of N/A could occur due to a lock or a disconnection race but not during connection setup.
-
jonatack cross-referenced this on Nov 17, 2022 from issue rpc: Always return getpeerinfo "relaytxes" field by jonatack
-
jarolrod added the label UI on Nov 17, 2022
-
jarolrod approved
-
jarolrod commented at 6:58 am on November 17, 2022: member
ACK 7a53033303f25301675fb2d7c7b7032166807910
The extra note here is redundant anyway at a UI level; it’s not as if you’re going to have a script that is dependent on the value the GUI is showing for this when setting up a peer.
One note: it’s always nice to add a translation comment to strings as we are updating them. For strings in the
.ui
files, you can add anextracomment
property to the string tag like so:0<string extracomment="nice translator comment">
master pr -
maflcko merged this on Nov 17, 2022
-
maflcko closed this on Nov 17, 2022
-
jonatack deleted the branch on Nov 17, 2022
-
sidhujag referenced this in commit 1b969ba2d0 on Nov 18, 2022
-
fanquake cross-referenced this on Dec 5, 2022 from issue [24.x] backport rpc: Require NodeStateStats object in getpeerinfo by jonatack
-
jonatack referenced this in commit ba28fa73d6 on Jan 10, 2023
-
bitcoin-core locked this on Nov 17, 2023
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 13:20 UTC
This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 13:20 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me