Fix Transaction Relay tooltip text in Peers details window #681

pull jonatack wants to merge 1 commits into bitcoin-core:master from jonatack:relaytxes-tooltip-fix changing 1 files +1 −1
  1. jonatack commented at 4:57 am on November 17, 2022: contributor
    as a value of N/A could occur due to a lock or a disconnection race but not during connection setup – see https://github.com/bitcoin/bitcoin/pull/26457#pullrequestreview-1181641835. Credit to Martin Zumsande for finding this.
  2. Fix Transaction Relay tooltip text in Peers details window
    as a value of N/A could occur due to a lock or a disconnection race
    but not during connection setup.
    7a53033303
  3. jonatack cross-referenced this on Nov 17, 2022 from issue rpc: Always return getpeerinfo "relaytxes" field by jonatack
  4. jarolrod added the label UI on Nov 17, 2022
  5. jarolrod approved
  6. jarolrod commented at 6:58 am on November 17, 2022: member

    ACK 7a53033303f25301675fb2d7c7b7032166807910

    The extra note here is redundant anyway at a UI level; it’s not as if you’re going to have a script that is dependent on the value the GUI is showing for this when setting up a peer.

    One note: it’s always nice to add a translation comment to strings as we are updating them. For strings in the .ui files, you can add an extracomment property to the string tag like so:

    0<string extracomment="nice translator comment">
    
    master pr
  7. maflcko merged this on Nov 17, 2022
  8. maflcko closed this on Nov 17, 2022

  9. jonatack deleted the branch on Nov 17, 2022
  10. jonatack commented at 5:39 pm on November 17, 2022: contributor
    Thanks, @jarolrod! I’ll try to keep your translation comment suggestion in mind.
  11. sidhujag referenced this in commit 1b969ba2d0 on Nov 18, 2022
  12. fanquake cross-referenced this on Dec 5, 2022 from issue [24.x] backport rpc: Require NodeStateStats object in getpeerinfo by jonatack
  13. jonatack referenced this in commit ba28fa73d6 on Jan 10, 2023
  14. bitcoin-core locked this on Nov 17, 2023


jonatack jarolrod

Labels
UI


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-23 00:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me