clang-tidy: Force checks for headers in src/qt #686

1. 
   hebasto commented at 11:59 am on December 16, 2022: member

   This PR split from bitcoin/bitcoin#26705 and contains only changes in src/qt.

   Effectively, it fixes the clang-tidy’s modernize-use-default-member-init errors, and forces clang-tidy checks for all headers in the src/qt directory.

2. clang-tidy, qt: Fix `modernize-use-default-member-init` in headers

   See https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-default-member-init.html

   69eacf2c5e
3. clang-tidy, qt: Force checks for headers in `src/qt` 7b7cd11244
4. 
   DrahtBot commented at 11:59 am on December 16, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	jarolrod

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #684 (Improve ‘Requested Payments History’ Multiselect by john-moffett)
   • #662 (Fix transaction view/table by luke-jr)
   • #658 (Intro: Never change the prune checkbox after the user has touched it by luke-jr)
   • #537 (Point out position of invalid characters in Bech32 addresses by luke-jr)
   • #497 (Enable users to configure their monospace font specifically by luke-jr)
   • #152 (Initialise DBus notifications in another thread by luke-jr)
   • #bitcoin/bitcoin/26858 (wallet: Use defined purposes instead of inlining by aureleoules)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. hebasto cross-referenced this on Dec 16, 2022 from issue clang-tidy: Fix `modernize-use-default-member-init` in headers and force to check all headers by hebasto
6. DrahtBot cross-referenced this on Dec 17, 2022 from issue Improve 'Requested Payments History' Multiselect by john-moffett
7. DrahtBot cross-referenced this on Dec 17, 2022 from issue Fix transaction view/table by luke-jr
8. DrahtBot cross-referenced this on Dec 17, 2022 from issue Intro: Never change the prune checkbox after the user has touched it by luke-jr
9. DrahtBot cross-referenced this on Dec 17, 2022 from issue Point out position of invalid characters in Bech32 addresses by luke-jr
10. DrahtBot cross-referenced this on Dec 17, 2022 from issue Enable users to configure their monospace font specifically by luke-jr
11. DrahtBot cross-referenced this on Dec 17, 2022 from issue Initialise DBus notifications in another thread by luke-jr
12. maflcko added the label Refactoring on Dec 17, 2022
13. 
    hebasto commented at 8:09 am on December 20, 2022: member

    Friendly ping @jarolrod :)
14. hebasto renamed this:
    clang-tidy, qt: Force checks for headers in `src/qt`
    clang-tidy: Force checks for headers in `src/qt`
    on Dec 20, 2022
15. DrahtBot cross-referenced this on Jan 13, 2023 from issue wallet: Use defined purposes instead of inlining by aureleoules
16. jarolrod approved
17. 
    jarolrod commented at 5:38 am on January 17, 2023: member

    ACK 7b7cd112444b996a8ae6a6edfed00bcee67546c8

    To confirm the correctness of the changes, I dropped the first commit and ran the CI locally. The log for the tidy task states what to fix, I went through this, painstakingly, for a long time, and arrived to the same diff as this PR.

    Also did some light testing of the binary with these changes. Also, CI is happy.

18. hebasto merged this on Jan 17, 2023
19. hebasto closed this on Jan 17, 2023

    ---

20. hebasto cross-referenced this on Jan 17, 2023 from issue clang-tidy: Add more `performance-*` checks and related fixes by hebasto
21. sidhujag referenced this in commit 418de2bf6e on Jan 17, 2023
22. bitcoin-core locked this on Jan 17, 2024

Contributors
hebasto DrahtBot jarolrod

Labels
Refactoring