If a user opens multiple wallets in the GUI from the menu bar, the last one opened is the active one in the main window. However, For the RPC Console window, the first one opened is active. This can be confusing, as wallet RPC commands may be sent to a wallet the user didn’t intend.
This PR makes the RPC Console switch to the wallet just opened / restored / created from the menu bar, which is how the main GUI now works.
Similar to #665 and specifically requested in a comment.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Is there any guidance on what to do in cases of (almost certainly) spurious CI test failures? The test failed here:
It seems this behavior is expected in very rare cases. I imagine that asking for a manual CI restart is preferred over (say) force pushing an empty amended commit?
I imagine that asking for a manual CI restart is preferred
Restarted.
57@@ -58,6 +58,7 @@ class RPCConsole: public QWidget
58 #ifdef ENABLE_WALLET
59 void addWallet(WalletModel* const walletModel);
60 void removeWallet(WalletModel* const walletModel);
61+ void SetCurrentWallet(WalletModel* const wallet_model);
Should it be declared as a slot?
In the qt subdirectory we usually follow Qt’s naming convention. Mind renaming please
0 void setCurrentWallet(WalletModel* const wallet_model);
?
const has no effect here.
797@@ -798,6 +798,12 @@ void RPCConsole::removeWallet(WalletModel * const walletModel)
798 ui->WalletSelectorLabel->setVisible(false);
799 }
800 }
801+
802+void RPCConsole::SetCurrentWallet(WalletModel* const wallet_model)
const? The parameter of all connected signals is WalletModel* wallet_model, right?
const here. Seems pretty reasonable, though it only has a net effect of preventing accidentally changing wallet_model in this method.
setCurrentWallet
If a user opens multiple wallets in the GUI from the
menu bar, the last one opened is the active one in
the main window. However, For the RPC Console window,
the _first_ one opened is active. This can be
confusing, as wallet RPC commands may be sent to a
wallet the user didn't intend.
This commit makes the RPC Console switch to the wallet
opened from the menu bar.