gui: Show labels for multiple SendToSelf addresses #698

pull john-moffett wants to merge 1 commits into bitcoin-core:master from john-moffett:2023_01_LabelsForPayToSelf changing 1 files +10 −2
  1. john-moffett commented at 1:34 PM on January 19, 2023: contributor

    Currently, the transaction table will display an address label for self-payments only if there's one recipient (ie - if you've sent your entire balance to one address you own).

    This PR changes it to show labels for any addresses that have labels in the address book. It's a follow-up to https://github.com/bitcoin/bitcoin/pull/15098.

    Before:

    <img width="1523" alt="image" src="https://user-images.githubusercontent.com/116917595/213289483-816c2580-d9fc-4cda-9aae-6f1b212dd020.png">

    After:

    <img width="1521" alt="image" src="https://user-images.githubusercontent.com/116917595/213289838-b05d838d-745c-4d64-a874-ec31bd62ef99.png">

    The addresses are stored in wtx->address separated by , , so split the string and call lookupAddress for each one.

  2. Show labels for multiple SendToSelf addresses
    Currently, the transaction table will display address
labels for self-payments if there's only one recipient
- ie - if you've sent your entire balance to yourself.

This changes it to show labels for any addresses that
have labels in the address book.
    14f3caa1c5
  3. DrahtBot commented at 1:34 PM on January 19, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #119 (Replace send-to-self with dual send+receive entries by luke-jr)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. DrahtBot cross-referenced this on Jan 19, 2023 from issue Replace send-to-self with dual send+receive entries by luke-jr
  5. john-moffett commented at 9:53 PM on January 23, 2023: contributor

    Closing because I think #119 is superior.

  6. john-moffett closed this on Jan 23, 2023
  7. bitcoin-core locked this on Jan 23, 2024
Contributors
john-moffettDrahtBot
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 16:20 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me