Map Ctrl+0 to clear RPC console #702

pull RandyMcMillan wants to merge 1 commits into bitcoin-core:master from RandyMcMillan:1674512069/5271c77f8/a62231bca-console-clear-key-code changing 1 files +6 −1
  1. RandyMcMillan commented at 2:58 am on January 24, 2023: contributor
    Ctrl+0 (zero) is mapped to clear the gui console.
  2. gui:rpcconsole.cpp: map Ctrl+0 to clear RPC console f07a2821de
  3. DrahtBot commented at 2:58 am on January 24, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #505 (RPCConsole: add hidePeersDetailButton and connect to RPCConsole::clearSelectedNode by RandyMcMillan)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. RandyMcMillan commented at 3:11 am on January 24, 2023: contributor

    Mapping Ctrl+0 to clear the console enables Ctrl + Ctrl - and Ctrl 0 functionality to be accessible from the same region on the keyboard.

    https://user-images.githubusercontent.com/152159/214204382-0343f726-a746-4f8e-ac24-5810433e68fd.mov

  5. DrahtBot cross-referenced this on Jan 24, 2023 from issue Hide Peers Detail Button by RandyMcMillan
  6. jarolrod added the label Feature on Jan 27, 2023
  7. jarolrod added the label UX on Jan 27, 2023
  8. jarolrod commented at 10:03 pm on January 27, 2023: member

    Is this a common accessibility related shortcut to clear a console? Qt docs show that Ctrl+0 is commonly used to reset the size of something back to its original size. For example in qt creator, its used to reset something to it’s original size whether that be an image or font: https://doc.qt.io/qtcreator/creator-keyboard-shortcuts.html

    The current shortcut to clear the console is Control + L. In relation to consoles, this is the normally used shortcut for the clear command.

  9. RandyMcMillan commented at 4:43 pm on January 28, 2023: contributor
    thanks for the feed back - maybe we just need to make these shortcuts more obvious in the gui - i will rethink this. But i still like having these related key commands close to one another - from a purely ergonomic perspective.
  10. jarolrod commented at 5:04 pm on January 28, 2023: member
    @RandyMcMillan for now, the shortcuts for actuating the console buttons are stated in the console welcome text. Maybe you’d like to explore making these more obvious? 2023-01-28_12-01
  11. RandyMcMillan commented at 0:01 am on January 29, 2023: contributor
    i “see” the issue - the dark green in dark mode doesn’t have enough contrast to the back ground - i literally didn’t see it. (my setup is unusual right now - working on a remote M1 - the screen share is small) :) image
  12. RandyMcMillan marked this as a draft on Jan 31, 2023
  13. hebasto renamed this:
    gui: map Ctrl+0 to clear RPC console
    Map Ctrl+0 to clear RPC console
    on Feb 2, 2023
  14. jarolrod commented at 2:13 am on February 3, 2023: member
    @RandyMcMillan I suppose this can be closed? wdyt?
  15. RandyMcMillan closed this on Feb 6, 2023

  16. bitcoin-core locked this on Feb 6, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 13:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me